Skip to content

Try to be a little bit smarter on fudge inference#158453

Open
ShoyuVanilla wants to merge 1 commit into
rust-lang:mainfrom
ShoyuVanilla:fuuudge
Open

Try to be a little bit smarter on fudge inference#158453
ShoyuVanilla wants to merge 1 commit into
rust-lang:mainfrom
ShoyuVanilla:fuuudge

Conversation

@ShoyuVanilla

@ShoyuVanilla ShoyuVanilla commented Jun 26, 2026

Copy link
Copy Markdown
Member

r? lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 26, 2026
ShoyuVanilla
ShoyuVanilla commented Jun 26, 2026
View reviewed changes
Comment thread compiler/rustc_hir_typeck/src/fn_ctxt/checks.rs
@ShoyuVanilla

ShoyuVanilla commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 26, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jun 26, 2026
@bors
Auto merge of #158453 - ShoyuVanilla:fuuudge, r=<try>
0a5c61e 
Try to be a little bit smarter on fudge inference
lcnr
lcnr reviewed Jun 26, 2026
View reviewed changes
Comment thread compiler/rustc_infer/src/infer/snapshot/fudge.rs Outdated
fn fold_ty(&mut self, ty: Ty<'tcx>) -> Ty<'tcx> {
if let &ty::Infer(infer_ty) = ty.kind() {
match infer_ty {
*self.var_map.entry(infer_ty).or_insert_with(|| match infer_ty {

@lcnr lcnr Jun 26, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also needs to happen or const and regions?

View changes since the review

@ShoyuVanilla ShoyuVanilla Jun 26, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my bad 😅

@ShoyuVanilla

ShoyuVanilla commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

@bors try cancel

@rust-bors

rust-bors Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Try build cancelled. Cancelled workflows:

@ShoyuVanilla

ShoyuVanilla commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jun 26, 2026
@bors
Auto merge of #158453 - ShoyuVanilla:fuuudge, r=<try>
4834b95 
Try to be a little bit smarter on fudge inference
@rust-bors

rust-bors Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 4834b95 (4834b952a27126ee96e1e1bb8560af00950877f6)
Base parent: eb6346c (eb6346c659ccb0468a1477c716ca5450a1fa9ba1)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (4834b95): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -3.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.9% [-3.9%, -3.9%] 1
All ❌✅ (primary) - - 0

Cycles

Results (secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 5.2% [5.2%, 5.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.4% [-2.4%, -2.4%] 2
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 485.381s -> 484.372s (-0.21%)
Artifact size: 392.99 MiB -> 393.53 MiB (0.14%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcnr lcnr lcnr left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@lcnr lcnr

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ShoyuVanilla @rust-timer @lcnr @rustbot