Replace the Tutorial with the Guide.#16657
Conversation
|
This kills all links to the tutorial over the internet; maybe it could be replaced with a more graceful "deprecation" page? |
|
That's true. We may want to leave that up for a bit. Previous things just got nuked, but it might be nice to be more graceful here. |
|
@huonw fixed, at least the basics. what do you think? |
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh, wait; I see you've adjusted the PDF generation above.
There was a problem hiding this comment.
Yup! and the link won't work until this all gets generated.
|
@brson this one is good to go, though 😉 😄 |
|
You have added the new guide to LaTeX PDF build rules instead of the tutorial but it can’t build it properly, I’d say it’s hitting #12804. |
|
It builds properly locally. |
|
Incl. LaTeX PDF docs? (it’s optional) Are you using pdflatex as a compiler? |
|
yup. |
steveklabnik
force-pushed
the
goodbye_tutorial
branch
from
c41c114 to
3e7e462
Compare
|
Rebased to remove the (odd) merge conflict. I still have no idea why this works for me but fails on the buildbot. Can anyone help? |
|
Awesome news! I can't reproduce this on the bots... |
|
Oh, wait. I can. WTF. |
|
For some reason, the build succeeded the first try. On the second try, guide.pdf does get created, but the build still fails. |
|
And that time the build succeeded... |
|
Oh, I see what's happening. Because the build failure leaves guide.pdf on disk, subsequent runs succeed. |
steveklabnik
force-pushed
the
goodbye_tutorial
branch
from
3e7e462 to
9a1a761
Compare
|
Rebased off of HEAD again |
|
pdflatex gives no indication what the error is. both things that it prints appear to be 'normal'; just returns an error code of 1 for mysterious reasons. |
|
Ah, indeed the problem is #12804. If you run pdflatex not in 'batchmode' it prints |
|
Oh iiiiinteresting. That'd be why I couldn't fix it locally, because I had a |
|
I'm preparing the patch @adrientetar suggests, preferring lualatex to pdflatex. Need to make sure the snapshot bots understand luatex. |
|
The dist/snap bots have xalatex, not lualatex, and it seems to not work correctly, so more work to do. |
|
@huonw while that's true, handling unicode characters is still very, very useful. |
|
I don't disagree, but this provides a low-automation way to land this. :) |
Bugs in pdflatex (#12804) are preventing the guide from landing (#16657). This solves the immediate problem by changing the build system to prefer lualatex, xelatex to pdflatex (which is apparently obsolete). Because the xelatex on the snapshot bot seems to completely ignore the `-output-directory` option, I also had to frob the makefiles a bit for that case.
|
Needs rebase. |
The Guide isn't 100% perfect, but it's basically complete. It's certainly better than the tutorial is. Time to start pointing more people its way. I also just made it consistent to call all things 'guides' rather than tutorials. Fixes rust-lang#9874. This is the big one. And two bugs that just go away. Fixes rust-lang#14503. Fixes rust-lang#15009.
steveklabnik
force-pushed
the
goodbye_tutorial
branch
from
9a1a761 to
c456cca
Compare
|
Foiled by my own PR! Updated. |
The Guide isn't 100% perfect, but it's basically complete. It's certainly better than the tutorial is. Time to start pointing more people its way. I also just made it consistent to call all things 'guides' rather than tutorials. Fixes #9874. This is the big one. And two bugs that just go away. Fixes #14503. Fixes #15009.
5 participants
The Guide isn't 100% perfect, but it's basically complete. It's
certainly better than the tutorial is. Time to start pointing more
people its way.
I also just made it consistent to call all things 'guides' rather than
tutorials.
Fixes #9874. This is the big one.
And two bugs that just go away.
Fixes #14503.
Fixes #15009.