Skip to content

[Rustbook] add next/prev section links in the book -- using js#21494

Merged
alexcrichton merged 1 commit into
rust-lang:masterfrom
jatinn:jsnav
Jan 31, 2015
Merged

[Rustbook] add next/prev section links in the book -- using js#21494
alexcrichton merged 1 commit into
rust-lang:masterfrom
jatinn:jsnav

Conversation

@jatinn

@jatinn jatinn commented Jan 22, 2015

Copy link
Copy Markdown
Contributor

Added javascript code to insert next/prev links in the rust book.
Related Issue - #20835

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik

Copy link
Copy Markdown
Contributor

Thanks @jatinn !

@gankro , what do you think of this PR?

Comment thread src/rustbook/css.rs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't increment these, they're useless.

@Gankra

Gankra commented Jan 23, 2015

Copy link
Copy Markdown
Contributor

Would you be able to build rustbook with these changes and host a copy for us to review the changes in production?

@jatinn

jatinn commented Jan 23, 2015

Copy link
Copy Markdown
Contributor Author

Sure here you go http://jatinn.github.io/rust/README.html
Also should i go back and change the copyright year back to 2014? I thought in the contribution notes it mentioned updating it.

@Gankra

Gankra commented Jan 23, 2015

Copy link
Copy Markdown
Contributor

@jatinn copyright stuff is in flux. See #21481 for discussion

@Gankra

Gankra commented Jan 23, 2015

Copy link
Copy Markdown
Contributor

This doesn't work if I visit: http://jatinn.github.io/rust/

@Gankra

Gankra commented Jan 23, 2015

Copy link
Copy Markdown
Contributor

Otherwise this looks great!

@Gankra

Gankra commented Jan 23, 2015

Copy link
Copy Markdown
Contributor

Although I would appreciate some comments noting what this code is for, and maybe desciribing the high-level logic ("search the TOC for this URL, and then grab the predecessor/successor, and toss them at the bottom of the page")

@jatinn

jatinn commented Jan 23, 2015

Copy link
Copy Markdown
Contributor Author

changes made

@Gankra

Gankra commented Jan 23, 2015

Copy link
Copy Markdown
Contributor

@jatinn one last nit: we have a style guide for comments to be // style. Change that, squash the commits into one, and r=me

@jatinn

jatinn commented Jan 23, 2015

Copy link
Copy Markdown
Contributor Author

r? @gankro

@Gankra

Gankra commented Jan 23, 2015

Copy link
Copy Markdown
Contributor

r+ e371d rollup

@Gankra

Gankra commented Jan 23, 2015

Copy link
Copy Markdown
Contributor

Thanks a ton!

barosl added a commit to barosl/rust that referenced this pull request Jan 27, 2015
Added javascript code to insert next/prev links in the rust book.
Related Issue - rust-lang#20835
@Gankra

Gankra commented Jan 29, 2015

Copy link
Copy Markdown
Contributor

fUCK

@Gankra

Gankra commented Jan 29, 2015

Copy link
Copy Markdown
Contributor

@bors r+ e371d rollup

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 30, 2015
Added javascript code to insert next/prev links in the rust book.
Related Issue - rust-lang#20835
@alexcrichton alexcrichton merged commit e371d23 into rust-lang:master Jan 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants