Skip to content

When elaborating predicates, purge duplicates from the initial vector.#21968

Merged
bors merged 4 commits intorust-lang:masterfrom
nikomatsakis:issue-21965-duplicate-preds-in-env
Feb 7, 2015
Merged

When elaborating predicates, purge duplicates from the initial vector.#21968
bors merged 4 commits intorust-lang:masterfrom
nikomatsakis:issue-21965-duplicate-preds-in-env

Conversation

@nikomatsakis
Copy link
Copy Markdown
Contributor

We were already building a hashset to check for duplicates, but we assumed that the initial vector had no duplicates. Fixes #21965.

r? @pnkfelix

@pnkfelix
Copy link
Copy Markdown
Contributor

pnkfelix commented Feb 5, 2015

@bors: r+ be8d9bb

…move this overeager code that was pruning out ambig where-clause matches in trait selection. cc rust-lang#21974.
@nikomatsakis
Copy link
Copy Markdown
Contributor Author

@pnkfelix I added 2 more commits to this

@pnkfelix
Copy link
Copy Markdown
Contributor

pnkfelix commented Feb 5, 2015

@bors: r+ bbf0898

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 6, 2015
…preds-in-env, r=pnkfelix

 We were already building a hashset to check for duplicates, but we assumed that the initial vector had no duplicates. Fixes rust-lang#21965.

r? @pnkfelix
@bors bors merged commit bbf0898 into rust-lang:master Feb 7, 2015
@nikomatsakis nikomatsakis deleted the issue-21965-duplicate-preds-in-env branch March 30, 2016 16:14
lnicola added a commit to lnicola/rust that referenced this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate predicates cause ambiguities when normalized associated types

3 participants