Remove noalias on return values#22018
Closed
dotdash wants to merge 1 commit intorust-lang:masterfrom
Closed
Conversation
On return values `noalias` has a stricter meaning than on arguments. It
means that the function is malloc-like. To quote the LLVM docs:
Furthermore, the semantics of the noalias attribute on return values
are stronger than the semantics of the attribute when used on
function arguments. On function return values, the noalias attribute
indicates that the function acts like a system memory allocation
function, returning a pointer to allocated storage disjoint from the
storage for any other object accessible to the caller.
We use it for all kinds of functions, which is wrong, so let's stop
doing that.
Fixes rust-lang#21996
Contributor
|
r? @nick29581 (rust_highfive has picked a reviewer for you, use r? to override) |
Member
Member
|
@bors: r- |
Contributor
Author
|
I just realized that the rationale given here makes no sense at all. The attribute is on a sret argument, not actually a return value. Will need more analysis |
Contributor
Author
|
Yeah, this just worked around the actual issue that caused #21996. |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2026
fix: enable vscode suggest in strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On return values
noaliashas a stricter meaning than on arguments. Itmeans that the function is malloc-like. To quote the LLVM docs:
We use it for all kinds of functions, which is wrong, so let's stop
doing that.
Fixes #21996