Skip to content

Add quasiquote for matchers and attributes#22061

Merged
bors merged 1 commit into
rust-lang:masterfrom
pczarn:quote_matcher_and_attr
Mar 5, 2015
Merged

Add quasiquote for matchers and attributes#22061
bors merged 1 commit into
rust-lang:masterfrom
pczarn:quote_matcher_and_attr

Conversation

@pczarn

@pczarn pczarn commented Feb 7, 2015

Copy link
Copy Markdown
Contributor

Fixes #19674
Fixes #17396 (already closed, yeah)

cc @kmcallister , @cmr

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@pczarn pczarn force-pushed the quote_matcher_and_attr branch from 5a61750 to 1c7aafa Compare February 7, 2015 21:39
@alexcrichton alexcrichton removed their assignment Feb 9, 2015
@alexcrichton

Copy link
Copy Markdown
Member

r? @kmcallister

Comment thread src/libsyntax/ext/quote.rs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this to the top as

if !matcher {
    panic!("TtSequence in quote!");
}

and then un-indent the bulk of the code?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@pczarn pczarn force-pushed the quote_matcher_and_attr branch 2 times, most recently from d75fbf5 to 4e355e2 Compare February 24, 2015 18:56
@kmcallister

Copy link
Copy Markdown
Contributor

r=me with those two things

@pczarn pczarn force-pushed the quote_matcher_and_attr branch from 4e355e2 to 3541abe Compare March 4, 2015 15:13
@pczarn

pczarn commented Mar 4, 2015

Copy link
Copy Markdown
Contributor Author

Updated, tested.

@kmcallister

Copy link
Copy Markdown
Contributor

@bors r+ 3541abe

@bors

bors commented Mar 4, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 3541abe with merge 7350162...

@Manishearth

Copy link
Copy Markdown
Member

(I might be forcebuilding the rollup, so the build may fail a couple of times here, sorry in advance)

@bors

bors commented Mar 4, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-64-x-android-t

@Manishearth

Copy link
Copy Markdown
Member

@bors: retry

@Manishearth

Copy link
Copy Markdown
Member

In case the rollup causes a merge conflict, here is the fix: 290caba

@bors

bors commented Mar 5, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 3541abe with merge 68740b4...

bors added a commit that referenced this pull request Mar 5, 2015
@bors

bors commented Mar 5, 2015

Copy link
Copy Markdown
Collaborator

@bors bors merged commit 3541abe into rust-lang:master Mar 5, 2015
@bors bors mentioned this pull request Mar 5, 2015
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add quasiquote for attributes Better integration between MBE and procedural macros

6 participants