Skip to content

Use arrays instead of vectors in tests#22623

Merged
bors merged 2 commits into
rust-lang:masterfrom
petrochenkov:optest
Feb 25, 2015
Merged

Use arrays instead of vectors in tests#22623
bors merged 2 commits into
rust-lang:masterfrom
petrochenkov:optest

Conversation

@petrochenkov

Copy link
Copy Markdown
Contributor

Tests often use vec![1, 2, 3] instead of shorter and faster [1, 2, 3].
This patch removes a lot of unnecessary vec!s. Hopefully, the tests will compile and run a bit faster.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+ 2e91dc0

@Manishearth

Copy link
Copy Markdown
Member

Needs rebase.

@petrochenkov

Copy link
Copy Markdown
Contributor Author

Rebased and removed some more vec!s from newer code.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will this work?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, it works. Never mind :)

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+ 2807a1c

@petrochenkov

Copy link
Copy Markdown
Contributor Author

It didn't pass local make check, I've fixed the broken test.

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+ c11807d

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 24, 2015
 Tests often use `vec![1, 2, 3]` instead of shorter and faster `[1, 2, 3]`.
This patch removes a lot of unnecessary `vec!`s. Hopefully, the tests will compile and run a bit faster.
@bors

bors commented Feb 25, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c11807d with merge 0e5d8b8...

@bors

bors commented Feb 25, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-64-x-android-t

@bors bors merged commit c11807d into rust-lang:master Feb 25, 2015
@petrochenkov petrochenkov deleted the optest branch May 9, 2015 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants