Eliminate more excessive null-checks from slice iterators#22669
Conversation
This adds the assume() calls back that got lost when rebasing rust-lang#21886.
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ e457 |
|
I think that unfortunately this doesn't work on windows: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/3435/steps/compile/logs/stdio |
|
Oh, #22395 accidently reverted LLVM to an older version that doesn't contain my fix to make |
|
@bors r- r- for now until the llvm fix has landed (again) |
|
Ach sorry about that :( Feel free to re-include the update in this PR and send it back to bors. |
|
I'll just wait for the new llvmup PR. It will merge eventually, I suppose ;-) |
|
@bors r=huonw e457 |
|
💔 Test failed - auto-win-32-nopt-t |
|
Ah, due to the previous revert to the old llvm version, the snapshot uses the old llvm again and so it crashes in stage0 sigh |
|
Now that new llvm landed, should this be working now? |
|
It would, if guarded by |
|
@bors retry Snapshot landed |
|
⌛ Testing commit e457328 with merge ef5b15c... |
|
💔 Test failed - auto-linux-64-x-android-t |
|
@bors: retry |
|
⚡ Previous build results are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt... |
|
💔 Test failed - auto-win-32-opt |
|
@bors: retry clean |
This adds the assume() calls back that got lost when rebasing #21886.
7 participants
This adds the assume() calls back that got lost when rebasing #21886.