Skip to content

Use trans_arg_datum in trans_args_under_call_abi#22923

Merged
bors merged 1 commit into
rust-lang:masterfrom
dotdash:trans_arg
Mar 2, 2015
Merged

Use trans_arg_datum in trans_args_under_call_abi#22923
bors merged 1 commit into
rust-lang:masterfrom
dotdash:trans_arg

Conversation

@dotdash

@dotdash dotdash commented Mar 1, 2015

Copy link
Copy Markdown
Contributor

The logic for the argument translation was duplicated here.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

Comment thread src/librustc_trans/trans/callee.rs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't this whole for loop be written as llargs.extend(field_types.map(|field_ty| ...))?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

The logic for the argument translation was duplicated here.
@eddyb

eddyb commented Mar 1, 2015

Copy link
Copy Markdown
Contributor

@bors r+ 708c385 rollup

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 1, 2015
 The logic for the argument translation was duplicated here.
@bors bors merged commit 708c385 into rust-lang:master Mar 2, 2015
@dotdash dotdash deleted the trans_arg branch May 8, 2015 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants