Skip to content

New section of the book: nightly rust#23719

Merged
bors merged 1 commit into
rust-lang:masterfrom
steveklabnik:unstable_book
Mar 28, 2015
Merged

New section of the book: nightly rust#23719
bors merged 1 commit into
rust-lang:masterfrom
steveklabnik:unstable_book

Conversation

@steveklabnik

Copy link
Copy Markdown
Contributor

Now that feature flags are only on nightly, it's good to split this stuff out.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik

Copy link
Copy Markdown
Contributor Author

This diff is basically just extracting all the parts of the book out, with the exception of trace_macros. The rest of it is just verbatim copy/paste.

@alexcrichton

Copy link
Copy Markdown
Member

Is the empty file src/doc/trpl/tracing-macros.md intentional?

@steveklabnik

Copy link
Copy Markdown
Contributor Author

Uh, no. Whoops!

Comment thread src/doc/trpl/unsafe.md

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section appears to have disappeared, was that intentional? (I'm ok if it was)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait nevermind this header just changed names and my search-fu failed me

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+ rollup

Nice idea!

@bors

bors commented Mar 25, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 7ef73ce has been approved by alexcrichton

@steveklabnik

Copy link
Copy Markdown
Contributor Author

🎊

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 26, 2015
…richton

Now that feature flags are only on nightly, it's good to split this stuff out.
@erickt

erickt commented Mar 26, 2015

Copy link
Copy Markdown
Contributor

I think this errored out in the rollup with:

rustc: x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/librustc_llvm
rustc: x86_64-apple-darwin/stage1/lib/rustlib/x86_64-apple-darwin/bin/rustbook
rustc: x86_64-apple-darwin/stage1/lib/rustlib/x86_64-apple-darwin/bin/rustdoc
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt/build/src/driver/driver.rs:15:14: 15:23 warning: obsolete syntax: "crate-name"
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt/build/src/driver/driver.rs:15 extern crate "rustdoc" as this;
                                                                                                    ^~~~~~~~~
note: use an identifier not in quotes instead
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt/build/src/driver/driver.rs:18:14: 18:28 warning: obsolete syntax: "crate-name"
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt/build/src/driver/driver.rs:18 extern crate "rustc_driver" as this;
                                                                                                    ^~~~~~~~~~~~~~
cp: x86_64-apple-darwin/stage2/lib/librustdoc
rustc: x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/libterm
rustc: x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/libserialize
cp: x86_64-apple-darwin/stage2/bin/rustbook
cp: x86_64-apple-darwin/stage2/bin/rustdoc
rustbook: doc/book/index.html
error: No such file or directory (os error 2)
make: *** [doc/book/index.html] Error 101
make: *** Waiting for unfinished jobs....
program finished with exit code 2
elapsedTime=2077.192005

Now that feature flags are only on nightly, it's good to split this stuff out.
@steveklabnik

Copy link
Copy Markdown
Contributor Author

I don't know what caused this error, but I'll rebase in case there's something weird, and let's just non-rollup this one.

@steveklabnik

Copy link
Copy Markdown
Contributor Author

@bors: r=alexcrichton

@bors

bors commented Mar 26, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit c153fc1 has been approved by alexcrichton

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 26, 2015
…richton

 Now that feature flags are only on nightly, it's good to split this stuff out.
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 27, 2015
Now that feature flags are only on nightly, it's good to split this stuff out.
@bors bors merged commit c153fc1 into rust-lang:master Mar 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants