Skip to content

Deprecate as_mut_slice methods#23721

Merged
bors merged 1 commit into
rust-lang:masterfrom
erickt:deprecate
Mar 28, 2015
Merged

Deprecate as_mut_slice methods#23721
bors merged 1 commit into
rust-lang:masterfrom
erickt:deprecate

Conversation

@erickt

@erickt erickt commented Mar 25, 2015

Copy link
Copy Markdown
Contributor

This is technically a breaking change as it deprecates and unstables some previously stable apis that were missed in the last round of deprecations.

[breaking change]

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+ 5ed703b

Thanks!

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 26, 2015
This is technically a breaking change as it deprecates and unstables some previously stable apis that were missed in the last round of deprecations.

[breaking change]
erickt added a commit to erickt/rust that referenced this pull request Mar 26, 2015
This is technically a breaking change as it deprecates and unstables some previously stable apis that were missed in the last round of deprecations.

[breaking change]
erickt added a commit to erickt/rust that referenced this pull request Mar 26, 2015
This is technically a breaking change as it deprecates and unstables some previously stable apis that were missed in the last round of deprecations.

[breaking change]
@bors

bors commented Mar 26, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5ed703b with merge ffcc8c4...

@bors

bors commented Mar 26, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-mac-32-opt

@tamird

tamird commented Mar 26, 2015

Copy link
Copy Markdown
Contributor
failures:

---- distributions::WeightedChoice_0 stdout ----
    <anon>:12:40: 12:54 error: use of unstable library feature 'collections': use &mut s[..] instead
<anon>:12     let wc = WeightedChoice::new(items.as_mut_slice());

@erickt

erickt commented Mar 26, 2015

Copy link
Copy Markdown
Contributor Author

@bors: retry

This is technically a breaking change as it deprecates and unstables
some previously stable apis that were missed in the last round of
deprecations.

[breaking change]
@erickt

erickt commented Mar 26, 2015

Copy link
Copy Markdown
Contributor Author

@bors: r+ rollup c5b8763

@bors

bors commented Mar 26, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit c5b8763 has been approved by erickt

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 26, 2015
 This is technically a breaking change as it deprecates and unstables some previously stable apis that were missed in the last round of deprecations.

[breaking change]
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 27, 2015
This is technically a breaking change as it deprecates and unstables some previously stable apis that were missed in the last round of deprecations.

[breaking change]
@bors bors merged commit c5b8763 into rust-lang:master Mar 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants