Skip to content

Improve information about loops#24750

Merged
bors merged 2 commits into
rust-lang:masterfrom
withoutboats:patch-1
Apr 24, 2015
Merged

Improve information about loops#24750
bors merged 2 commits into
rust-lang:masterfrom
withoutboats:patch-1

Conversation

@withoutboats

Copy link
Copy Markdown
Contributor
  1. Moved 'while' section below 'loop', 'break', and 'continue'; 2) Added information to 'while' and 'for' loops that they interact with 'break' and 'continue' and may have a lifetime label. 3) Clarified labeling syntax on the infinite loops.

1) Moved 'while' section below 'loop', 'break', and 'continue'; 2) Added information to 'while' and 'for' loops that they interact with 'break' and 'continue' and may have a lifetime label. 3) Clarified labeling syntax on the infinite loops.
@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik

Copy link
Copy Markdown
Contributor

Why move while down? Just curious.

@alexcrichton

Copy link
Copy Markdown
Member

r? @steveklabnik

@withoutboats

Copy link
Copy Markdown
Contributor Author

It was so it would not be antecedent to the information about break and continue (which it now references), and because (like for) it builds on the basic concept of loop.

@steveklabnik

Copy link
Copy Markdown
Contributor

Seems like a good reason. Thanks!

@steveklabnik

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

@bors

bors commented Apr 24, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 3ae6a5e has been approved by steveklabnik

@Diggsey

Diggsey commented Apr 24, 2015

Copy link
Copy Markdown
Contributor

The grammar for "while let" loops is missing the lifetime label and associated comment that break/continue work with it. (I've tested and rust does allow labels and break/continue here)

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 24, 2015
 1) Moved 'while' section below 'loop', 'break', and 'continue'; 2) Added information to 'while' and 'for' loops that they interact with 'break' and 'continue' and may have a lifetime label. 3) Clarified labeling syntax on the infinite loops.
@bors bors merged commit 3ae6a5e into rust-lang:master Apr 24, 2015
@withoutboats withoutboats deleted the patch-1 branch April 25, 2015 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants