Skip to content

Improve Debug documentation#25830

Merged
bors merged 1 commit into
rust-lang:masterfrom
steveklabnik:debug_docs
May 29, 2015
Merged

Improve Debug documentation#25830
bors merged 1 commit into
rust-lang:masterfrom
steveklabnik:debug_docs

Conversation

@steveklabnik

@steveklabnik steveklabnik commented May 27, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented May 27, 2015

Copy link
Copy Markdown
Contributor

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

sfackler
sfackler reviewed May 27, 2015
View reviewed changes
Comment thread src/libcore/fmt/mod.rs

@sfackler sfackler May 27, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth mentioning the debug builder methods for use by manual implementations (Formatter::debug_<foo>)

@steveklabnik steveklabnik May 27, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have never used these before. Will investigate.

@alexcrichton

alexcrichton commented May 27, 2015

Copy link
Copy Markdown
Member

I agree with @sfackler that a mention of the debug builders would be good here as well!

@steveklabnik

steveklabnik commented May 27, 2015

Copy link
Copy Markdown
Contributor Author

updated!

alexcrichton
alexcrichton reviewed May 27, 2015
View reviewed changes
Comment thread src/libcore/fmt/mod.rs Outdated

@alexcrichton alexcrichton May 27, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implemnetations

@alexcrichton

alexcrichton commented May 27, 2015

Copy link
Copy Markdown
Member

r=me with a minor typo, thanks!

@steveklabnik

steveklabnik commented May 27, 2015

Copy link
Copy Markdown
Contributor Author

@bors: r=alexcrichton rollup

@bors

bors commented May 27, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 8bfc027 has been approved by alexcrichton

@bors

bors commented May 28, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 8bfc027 with merge 115b327...

@bors

bors commented May 28, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-mac-64-opt

@steveklabnik

steveklabnik commented May 28, 2015

Copy link
Copy Markdown
Contributor Author

Sigh. Confirmed that tests pass now.

@steveklabnik

steveklabnik commented May 28, 2015

Copy link
Copy Markdown
Contributor Author

@bors: r=alexcrichton rollup

@bors

bors commented May 28, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 977d40f has been approved by alexcrichton

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 29, 2015
@steveklabnik
Rollup merge of rust-lang#25830 - steveklabnik:debug_docs, r=alexcric…
bee08ec 
…hton
@steveklabnik steveklabnik mentioned this pull request May 29, 2015
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 29, 2015
@steveklabnik
Rollup merge of rust-lang#25830 - steveklabnik:debug_docs, r=alexcric…
374a719 
…hton
@steveklabnik steveklabnik mentioned this pull request May 29, 2015
Closed
@bors

bors commented May 29, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 977d40f with merge 915dc2c...

@bors

bors commented May 29, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-64-opt

@alexcrichton

alexcrichton commented May 29, 2015

Copy link
Copy Markdown
Member

@bors: retry

On Thu, May 28, 2015 at 10:34 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-linux-64-opt
http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/5135

—
Reply to this email directly or view it on GitHub
#25830 (comment).

@bors

bors commented May 29, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 977d40f with merge b9eb606...

bors added a commit that referenced this pull request May 29, 2015
@bors
Auto merge of #25830 - steveklabnik:debug_docs, r=alexcrichton
b9eb606
@bors

bors commented May 29, 2015

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt

@bors bors merged commit 977d40f into rust-lang:master May 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichton alexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@steveklabnik @rust-highfive @alexcrichton @bors @sfackler @pcwalton