Extend dead code lint to detect more unused enum variants, rebased#25961
Merged
Conversation
Contributor
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
Could you add a test like: enum Foo { A, B }
fn bar() -> Foo {
match Foo::A {
Foo::A | Foo::B => Foo::B
}
}That is, ensuring that alternation doesn't get cause variants to count as unused. |
Member
|
r? @huonw |
Contributor
Author
|
Added a test. |
Contributor
Author
|
Ping? |
Contributor
Author
|
Another ping. |
Contributor
|
@bors r+ sorry for the delay |
Collaborator
|
📌 Commit 09a4d09 has been approved by |
Collaborator
|
⌛ Testing commit 09a4d09 with merge 6169aa2... |
Collaborator
|
💔 Test failed - auto-mac-64-nopt-t |
Contributor
Author
|
Failed in pretty. Fixed. |
Contributor
Author
|
@bors r=huonw |
Collaborator
|
📌 Commit ae0716d has been approved by |
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #21468.
Fix #25960.