Skip to content

Add priority policy to RWLock api doc#25988

Merged
bors merged 1 commit into
rust-lang:masterfrom
webmobster-zz:master
Jun 4, 2015
Merged

Add priority policy to RWLock api doc#25988
bors merged 1 commit into
rust-lang:masterfrom
webmobster-zz:master

Conversation

@webmobster-zz

@webmobster-zz webmobster-zz commented Jun 3, 2015

Copy link
Copy Markdown

The priority policy of RWLock is not specified, and the fact there is no policy should probably be specified.

@rust-highfive

rust-highfive commented Jun 3, 2015

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

steveklabnik
steveklabnik reviewed Jun 3, 2015
View reviewed changes
Comment thread src/libstd/sync/rwlock.rs Outdated

@steveklabnik steveklabnik Jun 3, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

system's

@steveklabnik

steveklabnik commented Jun 3, 2015

Copy link
Copy Markdown
Contributor

I am unsure how true this is, but if it is, 👍 from me

steveklabnik
steveklabnik reviewed Jun 3, 2015
View reviewed changes
Comment thread src/libstd/sync/rwlock.rs Outdated

@steveklabnik steveklabnik Jun 3, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"any particular policy"

@steveklabnik steveklabnik Jun 3, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"any particular policy"

@alexcrichton

alexcrichton commented Jun 3, 2015

Copy link
Copy Markdown
Member

Thanks! Could you also squash the commits together?

@webmobster-zz

webmobster-zz commented Jun 3, 2015

Copy link
Copy Markdown
Author

Updated with the changes. Thanks for the help

@alexcrichton

alexcrichton commented Jun 3, 2015

Copy link
Copy Markdown
Member

@bors: r+ 24808fa rollup

Thanks!

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 4, 2015
@Manishearth
Rollup merge of rust-lang#25988 - webmobster:master, r=alexcrichton
5421b1f 
The priority policy of RWLock is not specified, and the fact there is no policy should probably be specified.
@Manishearth Manishearth mentioned this pull request Jun 4, 2015
Merged
bors added a commit that referenced this pull request Jun 4, 2015
@bors
Auto merge of #26002 - Manishearth:rollup, r=Manishearth
0aeb9f6 
- Successful merges: #25900, #25987, #25988, #25990, #25994, #26000
- Failed merges:
@bors bors merged commit 24808fa into rust-lang:master Jun 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichton alexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@webmobster-zz @rust-highfive @steveklabnik @alexcrichton @bors @webmobster