OpenBSD don't support morestack#26213
Merged
Merged
Conversation
Contributor
Author
Collaborator
|
☔ The latest upstream changes (presumably #26197) made this pull request unmergeable. Please resolve the merge conflicts. |
semarie
force-pushed
the
openbsd-morestack
branch
from
815f322 to
85b7164
Compare
Contributor
Author
|
PR rebased |
Member
Contributor
Author
|
ping ? I would unbreak openbsd build. I could amend the patch for match only mac/linux (if someone tell me accurate variables to check). For windows, I don't think it should be included, as it is part of the current list of platforms that shouldn't have the snippet included. Does these variables should be ok ?
|
Member
|
Yeah I think checking those variables should be fine. |
instead of enumerate the (long) list of platforms to exclude, use only the short list of platforms to include. should fixes __morestack symbol problem under openbsd
semarie
force-pushed
the
openbsd-morestack
branch
from
85b7164 to
b804c24
Compare
Contributor
Author
|
@alexcrichton I have inversed the logic: code included only for linux and APPLE |
Member
bors
added a commit
that referenced
this pull request
Jun 14, 2015
don't try to bind __morestack symbol under OpenBSD as the platform don't have morestack support. r? @alexcrichton it unbreak build under OpenBSD. Does some others platforms don't have morestack too ? They should be impacted by this problem too.
Collaborator
Collaborator
|
@semarie I'm so sorry about that...I don't know why I forgot to add it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
don't try to bind __morestack symbol under OpenBSD as the platform don't
have morestack support.
r? @alexcrichton
it unbreak build under OpenBSD. Does some others platforms don't have morestack too ? They should be impacted by this problem too.