Deprecate _ms functions that predate the Duration API

[bstrie]

No description provided.

[rust-highfive]

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

[bstrie]

Given that aturon and acrichto seemed surprised to discover that these APIs had not been deprecated, would we want to backport these to beta? If so, then hold off approving this until I have the chance to change the "since" tags.

[sfackler]

Doesn't really seem worth backporting. Since we missed these in 1.4, it doesn't seem to matter a ton if we deprecate in 1.5 or 1.6.

[bstrie]

@sfackler Doesn't matter a ton, but it does add an additional six week period where people may use these functions accidentally.

[Gankra]

We backport very little. Basically only serious bug fixes. I don't care if people use this functionality, it's not exactly a footgun or anything, just a crufty interface.

[steveklabnik]

Yup, big 👎 to back porting.

On Nov 5, 2015, at 04:51, Alexis Beingessner notifications@github.com wrote:

We backport very little. Basically only serious bug fixes. I don't care if people use this functionality, it's not exactly a footgun or anything, just a crufty interface.

―
Reply to this email directly or view it on GitHub.

[alexcrichton]

I agree with others that it's ok to not backport this, we unfortunately missed the 1.5 train but another's always on the way! Regardless, though, thanks @bstrie!

@bors: r+ a2efa2a

[bors]

⌛ Testing commit a2efa2a with merge 6878fce...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt