mk: fix undefined variable warnings#30367
Conversation
tamird
force-pushed
the
fix-makefile-bugs
branch
12 times, most recently
from
cc8f66d to
62c36fe
Compare
|
@alexcrichton this is ready for a look |
There was a problem hiding this comment.
How come these all changed? Do shells warn about this kind of thing?
There was a problem hiding this comment.
They don't warn; these had to change because of the addition of eval $V = 0 on L266
|
☔ The latest upstream changes (presumably #27937) made this pull request unmergeable. Please resolve the merge conflicts. |
tamird
force-pushed
the
fix-makefile-bugs
branch
2 times, most recently
from
5dfcf99 to
521ffa4
Compare
|
The travis failure here seems worrisome? |
|
Yeah, I'll take a look tomorrow; out of time for the day! |
tamird
force-pushed
the
fix-makefile-bugs
branch
2 times, most recently
from
2b7dba4 to
5123218
Compare
tamird
force-pushed
the
fix-makefile-bugs
branch
3 times, most recently
from
62fc2df to
b31fee8
Compare
|
@alexcrichton PTAL. I've taken out the |
|
Ah wonderful! I had looked into trying to do this a while back, and didn't do it. Bravo! 👍 💯 |
|
I think the failures here are legit, looking into it |
|
☔ The latest upstream changes (presumably #30897) made this pull request unmergeable. Please resolve the merge conflicts. |
tamird
force-pushed
the
fix-makefile-bugs
branch
from
b31fee8 to
2b6a2db
Compare
|
Well, I wasn't able to reproduce any failures locally. Can I get another r+? |
|
@bors: r+ 2b7a2db |
|
🙀 |
|
@bors: r+ 2b6a2db |
|
⌛ Testing commit 2b6a2db with merge b3037dd... |
|
💔 Test failed - auto-linux-64-x-android-t |
|
☔ The latest upstream changes (presumably #31274) made this pull request unmergeable. Please resolve the merge conflicts. |
tamird
force-pushed
the
fix-makefile-bugs
branch
from
2b6a2db to
9a00709
Compare
|
@alexcrichton I believe I've fixed the android issue. Let's give it another go? |
|
@bors: r+ 9a007093fa58d3a25002d2275f2fedef5af671c9 |
|
⌛ Testing commit 9a00709 with merge 4d5b8d1... |
|
💔 Test failed - auto-linux-64-x-android-t |
Some of this is scary stuff. Probably time to lint against this. Found with `make --warn-undefined-variables`.
tamird
force-pushed
the
fix-makefile-bugs
branch
from
9a00709 to
d037129
Compare
|
sigh, |
Some of this is scary stuff. Probably time to lint against this. Found with `make --warn-undefined-variables`. r? @alexcrichton
5 participants
Some of this is scary stuff. Probably time to lint against this.
Found with
make --warn-undefined-variables.r? @alexcrichton