Skip to content

std: Update jemalloc version#30434

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:update-jemalloc
Dec 22, 2015
Merged

std: Update jemalloc version#30434
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:update-jemalloc

Conversation

@alexcrichton

Copy link
Copy Markdown
Member

It's been awhile since we last updated jemalloc, and there's likely some bugs
that have been fixed since the last version we're using, so let's try to update
again.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

Copy link
Copy Markdown
Member Author

I... forget the reason that this bounced in the past, and it may have been fixed upstream, so I figured we should try again.

@steveklabnik

Copy link
Copy Markdown
Contributor

@bors: r+

Let's refresh our memories.

@bors

bors commented Dec 17, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit aed7997 has been approved by steveklabnik

@bors

bors commented Dec 19, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit aed7997 with merge 8f431fa...

@bors

bors commented Dec 19, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-64-nopt-t

@steveklabnik

Copy link
Copy Markdown
Contributor

@bors: retry

On Dec 19, 2015, 09:07 -0500, borsnotifications@github.com, wrote:

Test failed -auto-linux-64-nopt-t(http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/7421)


Reply to this email directly orview it on GitHub(#30434 (comment)).

@bors

bors commented Dec 19, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit aed7997 with merge a692b0d...

@bors

bors commented Dec 19, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-32-nopt-t

@sfackler

Copy link
Copy Markdown
Member

@bors retry

@bors

bors commented Dec 20, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit aed7997 with merge aa1075c...

@bors

bors commented Dec 20, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-32-nopt-t

@retep998

Copy link
Copy Markdown
Contributor

Both bot failures failed with the error code STATUS_RESOURCE_NOT_OWNED which is described as "{Application Error} The application attempted to release a resource it did not own. Click OK to terminate the application."

@alexcrichton

Copy link
Copy Markdown
Member Author

@bors: r+ c0b868e133744dd0d23849671d818f5dcefe25ad

@bors

bors commented Dec 20, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c0b868e with merge 980c216...

@bors

bors commented Dec 20, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-64-opt

It's been awhile since we last updated jemalloc, and there's likely some bugs
that have been fixed since the last version we're using, so let's try to update
again.
@alexcrichton

Copy link
Copy Markdown
Member Author

@bors: r+ 9929c24

@alexcrichton

Copy link
Copy Markdown
Member Author

We're currently passing --enable-lazy-lock, but I think that's fundamentally broken on Windows, so I've switched it to an explicit --disable-lazy-lock (as it's enabled by default on MinGW). Local tests show that the failing tests here pass with a jemalloc built under that configuration, so I'm hoping that enables this to finally land!

@bors

bors commented Dec 21, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9929c24 with merge 5d4efcb...

bors added a commit that referenced this pull request Dec 21, 2015
It's been awhile since we last updated jemalloc, and there's likely some bugs
that have been fixed since the last version we're using, so let's try to update
again.
@bors bors merged commit 9929c24 into rust-lang:master Dec 22, 2015
@alexcrichton alexcrichton deleted the update-jemalloc branch December 22, 2015 01:38
@alexcrichton

Copy link
Copy Markdown
Member Author

🌴

@alexcrichton alexcrichton added the relnotes Marks issues that should be documented in the release notes of the next release. label Dec 22, 2015
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 20, 2016
We've been seeing a lot of timeouts in tests on the bots and investigation ended
pointing to jemalloc/jemalloc#315 as the culprit. Unfortunately it looks like
that doesn't seem to have a fix on the way soon, so let's temporarily downgrade
back to the previous version of jemalloc we were using (where rust-lang#30434 was the
most recent upgrade)
bors added a commit that referenced this pull request Jan 20, 2016
We've been seeing a lot of timeouts in tests on the bots and investigation ended
pointing to jemalloc/jemalloc#315 as the culprit. Unfortunately it looks like
that doesn't seem to have a fix on the way soon, so let's temporarily downgrade
back to the previous version of jemalloc we were using (where #30434 was the
most recent upgrade)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes Marks issues that should be documented in the release notes of the next release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants