Skip to content

Prettify MIR graphviz output#30469

Merged
bors merged 1 commit into
rust-lang:masterfrom
nagisa:mir-gv-prettify
Dec 20, 2015
Merged

Prettify MIR graphviz output#30469
bors merged 1 commit into
rust-lang:masterfrom
nagisa:mir-gv-prettify

Conversation

@nagisa

@nagisa nagisa commented Dec 18, 2015

Copy link
Copy Markdown
Member

One will look at graphviz often when working with MIR, so may as well make the tables a bit more
pretty :)

This is what it looks like now

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@luqmana

luqmana commented Dec 18, 2015

Copy link
Copy Markdown
Contributor

@bors: r+

@bors

bors commented Dec 18, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit d34417e has been approved by luqmana

@eddyb

eddyb commented Dec 18, 2015

Copy link
Copy Markdown
Contributor

cc @tsion

@solson

solson commented Dec 18, 2015

Copy link
Copy Markdown
Contributor

I have a PR that makes larger changes to the graphviz output, but I see no reason not to merge this now. Most of my changes are for the textual parts (especially constants). I don't have the cornsilk colored terminators, but I could add that if desired. :)

I'll try to get my PR ready ASAP.

One will look at graphviz often when working with MIR, so may as well make the tables a bit more
pretty :)
@nagisa

nagisa commented Dec 18, 2015

Copy link
Copy Markdown
Member Author

Fixed the build failure, re-r+?


@tsion sounds like our patches are pretty unrelated then? Either way, I’m completely fine rebasing onto you or you rebasing onto/merging me.

@solson

solson commented Dec 18, 2015

Copy link
Copy Markdown
Contributor

@nagisa I'll rebase onto yours. That'll be much simpler.

@luqmana

luqmana commented Dec 19, 2015

Copy link
Copy Markdown
Contributor

@bors: r+

@bors

bors commented Dec 19, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 03903cb has been approved by luqmana

@bors

bors commented Dec 20, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 03903cb with merge 48075cc...

@bors

bors commented Dec 20, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-32-opt

@alexcrichton

Copy link
Copy Markdown
Member

@bors: retry

On Sun, Dec 20, 2015 at 2:57 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-gnu-32-opt
http://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt/builds/2476


Reply to this email directly or view it on GitHub
#30469 (comment).

bors added a commit that referenced this pull request Dec 20, 2015
One will look at graphviz often when working with MIR, so may as well make the tables a bit more
pretty :)

![This is what it looks like now](https://cloud.githubusercontent.com/assets/679122/11908983/438f228e-a5ea-11e5-90bd-a2c2ec52412e.png)
@bors

bors commented Dec 20, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 03903cb with merge 19c997e...

@bors bors merged commit 03903cb into rust-lang:master Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants