Skip to content

enable cross crate and unsafe const fn#30899

Merged
bors merged 1 commit into
rust-lang:masterfrom
oli-obk:non-local-const-fn
Jan 25, 2016
Merged

enable cross crate and unsafe const fn#30899
bors merged 1 commit into
rust-lang:masterfrom
oli-obk:non-local-const-fn

Conversation

@oli-obk

@oli-obk oli-obk commented Jan 14, 2016

Copy link
Copy Markdown
Contributor

Also got rid of some code repetition in const_eval

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton

Copy link
Copy Markdown
Member

r? @pnkfelix

(or someone else who's done const-fn-related-stuff)

@bors

bors commented Jan 17, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #30975) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk oli-obk force-pushed the non-local-const-fn branch from c054c66 to f2c0ecd Compare January 17, 2016 14:24
@oli-obk

oli-obk commented Jan 19, 2016

Copy link
Copy Markdown
Contributor Author

rebased

@oli-obk

oli-obk commented Jan 25, 2016

Copy link
Copy Markdown
Contributor Author

ping @pnkfelix

@pnkfelix

Copy link
Copy Markdown
Contributor

@bors r+ f2c0ecd

@bors

bors commented Jan 25, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f2c0ecd with merge 62a3a6e...

bors added a commit that referenced this pull request Jan 25, 2016
Also got rid of some code repetition in `const_eval`
@bors bors merged commit f2c0ecd into rust-lang:master Jan 25, 2016
@oli-obk oli-obk deleted the non-local-const-fn branch January 26, 2016 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants