Skip to content

Clarify when Cargo.lock is created by cargo build in the book#31159

Merged
bors merged 1 commit into
rust-lang:masterfrom
dirk:dirk/clarify-cargo-lock
Jan 25, 2016
Merged

Clarify when Cargo.lock is created by cargo build in the book#31159
bors merged 1 commit into
rust-lang:masterfrom
dirk:dirk/clarify-cargo-lock

Conversation

@dirk

@dirk dirk commented Jan 24, 2016

Copy link
Copy Markdown
Contributor

Also remove a "finally" in the section about building for release to make it feel a bit friendlier.

Also remove a "finally" in the section about building for release
to make it feel a bit friendlier.
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@dirk

dirk commented Jan 24, 2016

Copy link
Copy Markdown
Contributor Author

This should close #31149 if/when it's merged.

@steveklabnik

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

Thank you!

This should close #31149 if/when it's merged.

For future reference: github will do this automatically if you include Closes #31159 or Fixes #31149 in your commit message.

@bors

bors commented Jan 24, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit a469cef has been approved by steveklabnik

@dirk

dirk commented Jan 24, 2016

Copy link
Copy Markdown
Contributor Author

D'oh. Forgot to include the "Closes #X" syntax in the message last night. Thanks for the reminder! 😛

On Jan 24, 2016, at 11:09 AM, Steve Klabnik notifications@github.com wrote:

@bors: r+ rollup

Thank you!

This should close #31149 if/when it's merged.

For future reference: github will do this automatically if you include Closes #31159 or Fixes #31149 in your commit message.


Reply to this email directly or view it on GitHub.

@bors

bors commented Jan 24, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit a469cef with merge 9bc2573...

@bors

bors commented Jan 24, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-mac-32-opt

@steveklabnik

Copy link
Copy Markdown
Contributor

@bors: retry

bors added a commit that referenced this pull request Jan 25, 2016
Also remove a "finally" in the section about building for release to make it feel a bit friendlier.
@bors

bors commented Jan 25, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit a469cef with merge 6866f13...

@bors bors merged commit a469cef into rust-lang:master Jan 25, 2016
@dirk dirk deleted the dirk/clarify-cargo-lock branch January 25, 2016 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants