Skip to content

Add tests for #26114#32010

Merged
bors merged 3 commits intorust-lang:masterfrom
devonhollowood:non-c-like-enum-repr
Mar 20, 2016
Merged

Add tests for #26114#32010
bors merged 3 commits intorust-lang:masterfrom
devonhollowood:non-c-like-enum-repr

Conversation

@devonhollowood
Copy link
Contributor

@devonhollowood devonhollowood commented Mar 2, 2016

First step in fixing #26114

@rust-highfive
Copy link
Contributor

rust-highfive commented Mar 2, 2016

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@devonhollowood devonhollowood mentioned this pull request Mar 2, 2016
Closed
@Manishearth
Copy link
Member

Manishearth commented Mar 2, 2016

@bors try

bors added a commit that referenced this pull request Mar 2, 2016
@bors
Auto merge of #32010 - devonhollowood:non-c-like-enum-repr, r=<try>
323c0b7 
First step in fixing #26114
@bors
Copy link
Collaborator

bors commented Mar 2, 2016

⌛ Trying commit 3f94fac with merge 323c0b7...

@Manishearth
Copy link
Member

Manishearth commented Mar 10, 2016

@bors try retry

@bors
Copy link
Collaborator

bors commented Mar 10, 2016

⌛ Trying commit b5be095 with merge 1e985d3...

bors added a commit that referenced this pull request Mar 10, 2016
@bors
Auto merge of #32010 - devonhollowood:non-c-like-enum-repr, r=<try>
1e985d3 
Add tests for #26114

First step in fixing #26114
@Manishearth
Copy link
Member

Manishearth commented Mar 10, 2016

r? @Aatch or @dotdash

@bors
Copy link
Collaborator

bors commented Mar 11, 2016

💥 Test timed out

@alexcrichton
Copy link
Member

alexcrichton commented Mar 11, 2016

@bors: retry

@bors
Copy link
Collaborator

bors commented Mar 11, 2016

⌛ Trying commit b5be095 with merge a1cc5b6...

bors added a commit that referenced this pull request Mar 11, 2016
@bors
Auto merge of #32010 - devonhollowood:non-c-like-enum-repr, r=<try>
a1cc5b6 
Add tests for #26114

First step in fixing #26114
@bors bors mentioned this pull request Mar 12, 2016
Merged
@bors
Copy link
Collaborator

bors commented Mar 12, 2016

💥 Test timed out

@alexcrichton
Copy link
Member

alexcrichton commented Mar 12, 2016

@bors: retry

@bors
Copy link
Collaborator

bors commented Mar 12, 2016

⌛ Trying commit b5be095 with merge 605713f...

@bors bors mentioned this pull request Mar 12, 2016
Merged
@bors
Copy link
Collaborator

bors commented Mar 12, 2016

💥 Test timed out

@alexcrichton
Copy link
Member

alexcrichton commented Mar 12, 2016

@bors: retry clean

@bors
Copy link
Collaborator

bors commented Mar 12, 2016

⌛ Trying commit b5be095 with merge b0d224f...

bors added a commit that referenced this pull request Mar 12, 2016
@bors
Auto merge of #32010 - devonhollowood:non-c-like-enum-repr, r=<try>
b0d224f 
Add tests for #26114

First step in fixing #26114
@bors
Copy link
Collaborator

bors commented Mar 13, 2016

💥 Test timed out

@devonhollowood
Copy link
Contributor Author

devonhollowood commented Mar 14, 2016

Not sure why this keeps timing out. Should I try submitting this again as a fresh pull request?

@alexcrichton
Copy link
Member

alexcrichton commented Mar 14, 2016

I think these are all from the @bors: try annotations, not from the actual tests themselves. This hasn't actually yet been approved.

@devonhollowood
Copy link
Contributor Author

devonhollowood commented Mar 15, 2016

@alexcrichton I meant that I'm not sure why the bors tries keep timing out. Is there some issue with bors right now?

@Aatch
Copy link
Contributor

Aatch commented Mar 15, 2016

I probably should have gotten to this earlier. Looks fine to me.

@Aatch
Copy link
Contributor

Aatch commented Mar 15, 2016

@bors: r+ b5be095

@Aatch
Copy link
Contributor

Aatch commented Mar 15, 2016

I'm going to assume that it's the try bots being weird, since they don't get used much.

@devonhollowood
Copy link
Contributor Author

devonhollowood commented Mar 20, 2016

It looks like this never re-entered the merge queue after @Aatch reviewed it. It still only has the failed try run on there.

@Manishearth
Copy link
Member

Manishearth commented Mar 20, 2016

@bors r=Aatch try- retry

@bors
Copy link
Collaborator

bors commented Mar 20, 2016

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Mar 20, 2016

📌 Commit b5be095 has been approved by Aatch

@bors
Copy link
Collaborator

bors commented Mar 20, 2016

⌛ Testing commit b5be095 with merge 2af3dd7...

bors added a commit that referenced this pull request Mar 20, 2016
@bors
Auto merge of #32010 - devonhollowood:non-c-like-enum-repr, r=Aatch
2af3dd7 
Add tests for #26114

First step in fixing #26114
@Manishearth
Copy link
Member

Manishearth commented Mar 20, 2016

Probably needed that retry there. back in the queue.

@devonhollowood
Copy link
Contributor Author

devonhollowood commented Mar 20, 2016

@Manishearth thanks!

@bors
Copy link
Collaborator

bors commented Mar 20, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-64-x-armhf, auto-linux-64-x-armsf, auto-linux-64-x-freebsd, auto-linux-64-x-netbsd, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild

@bors bors merged commit b5be095 into rust-lang:master Mar 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@brson brson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@devonhollowood @rust-highfive @Manishearth @bors @alexcrichton @Aatch @brson