Implement Default trait for OsString/OsStr#32404
Merged
bors merged 3 commits intorust-lang:masterfrom Mar 23, 2016
WiSaGaN:feature/osstring-implement-default
Merged
Implement Default trait for OsString/OsStr#32404bors merged 3 commits intorust-lang:masterfrom WiSaGaN:feature/osstring-implement-default
bors merged 3 commits intorust-lang:masterfrom
WiSaGaN:feature/osstring-implement-default
Conversation
Contributor
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
|
Hmm, what version attribute should I use? |
src/libstd/ffi/os_str.rs
Outdated
| } | ||
| } | ||
|
|
||
| #[stable(feature = "rust1", since = "1.9.0")] |
Contributor
There was a problem hiding this comment.
needs a new feature name. For example osstring_default (use same for both). Version 1.9.0 is ok I think since we are still in version 1.9.0 in the nightly.
Contributor
Author
Contributor
|
Looks good, thanks for the PR! @bors: r+ rollup |
Collaborator
|
📌 Commit b5b1d06 has been approved by |
Collaborator
|
⌛ Testing commit b5b1d06 with merge 99694f5... |
Collaborator
|
💔 Test failed - auto-win-gnu-64-opt |
Contributor
Author
|
Anything I can do here? |
Contributor
|
@bors retry I don't think so, seems like it didn't have a good reason to not complete. |
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Mar 23, 2016
…default, r=aturon Implement Default trait for OsString/OsStr Fixes rust-lang#32385
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32385