syntax: Make codemap::get_filemap() return an Option#33839
Merged
Conversation
This is more idiomatic, putting the caller in charge of whether or not to panic.
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
|
Admittedly, this is to allow more flexible use from syntex_syntax, but I still think thinks this change makes sense. |
Contributor
|
Seems fine. |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 3bef085 has been approved by |
Contributor
|
@bors r- |
Contributor
|
That said, ironically, this is a [plugin-breaking-change]. cc @Manishearth |
Contributor
Author
|
So small and yet... :-) |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 26, 2016
…ption, r=nmatsakis This is more idiomatic, putting the caller in charge of whether or not to panic.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 27, 2016
…ption, r=nmatsakis This is more idiomatic, putting the caller in charge of whether or not to panic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more idiomatic, putting the caller in charge of whether or not
to panic.