Revert "skip double negation in const eval"#34497
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 30, 2016
Merged
Conversation
This reverts commit 735c018.
eddyb
added
the
beta-nominated
Member
|
@bors r+ |
Collaborator
|
📌 Commit b8f9c88 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 29, 2016
Revert "skip double negation in const eval" This reverts commit 735c018. fixes rust-lang#34395 The original commit was based on a mis-understanding of the overflowing literal lint. This needs to be ported to beta. r? @eddyb
Member
|
cc @rust-lang/compiler thoughts on backporting? Would love to include this in the next beta we should produce fairly soon |
Member
|
+1 for packport |
Member
|
Discussed with compiler team in email as well and sentiment was that this is small enough and important enough to backport, accepting for backport. |
alexcrichton
added
the
beta-accepted
Member
alexcrichton
removed
the
beta-nominated
Contributor
Author
|
Lgtm, the failure was most likely due to 16bit support missing. There was a conflict during reverting in this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 735c018.
fixes #34395
The original commit was based on a mis-understanding of the overflowing literal lint.
This needs to be ported to beta.
r? @eddyb