Tweak std::rc docs by kmcallister · Pull Request #36571 · rust-lang/rust

kmcallister · 2016-09-18T23:09:40Z

Fixes #29372.

r? @GuillaumeGomez

frewsxcv · 2016-09-18T23:37:42Z

src/liballoc/rc.rs

Not a concrete suggestion, but these are called associated functions

Cool; added a note.

frewsxcv · 2016-09-18T23:39:58Z

src/liballoc/rc.rs

Alternatively, in order to prevent the code block from breaking up the sentence, it could also be something like:

In order to avoid name clashes with T's methods, the methods of Rc itself, such as downgrade, are called using function-like syntax:

Good idea; fixed.

frewsxcv · 2016-09-18T23:41:54Z

src/liballoc/rc.rs

Alternatively, assert_eq!

I went with == because we're talking about the definition of ==. Of course, assert_eq! uses == but it's an extra layer of indirection.

frewsxcv · 2016-09-18T23:42:07Z

src/liballoc/rc.rs

Alternatively, assert_eq!

I don't think there's an assert_neq!. Anyway, see above.

Just kidding, missed the !=. On a side note: rust-lang/rfcs#1653

kmcallister · 2016-09-19T18:33:44Z

btw, I'm updating Arc docs to match. That will be a separate PR.

Fixes rust-lang#29372.

kmcallister · 2016-09-21T17:26:01Z

Rebased and squashed.

GuillaumeGomez · 2016-09-21T17:26:57Z

Thanks a lot!

@bors: r+ rollup

bors · 2016-09-21T17:26:59Z

📌 Commit c316ae5 has been approved by GuillaumeGomez

@GuillaumeGomez

…cs, r=GuillaumeGomez Tweak std::rc docs Fixes rust-lang#29372. r? @GuillaumeGomez

@GuillaumeGomez

…cs, r=GuillaumeGomez Tweak std::rc docs Fixes rust-lang#29372. r? @GuillaumeGomez

Rollup of 7 pull requests - Successful merges: #36330, #36423, #36539, #36571, #36589, #36600, #36632 - Failed merges:

@GuillaumeGomez

Update Arc docs to match new Rc docs `Rc` docs were updated in rust-lang#36571. This applies similar changes to `Arc` docs. r? @GuillaumeGomez

rust-highfive assigned GuillaumeGomez Sep 18, 2016

frewsxcv approved these changes Sep 18, 2016

View reviewed changes

Tweak std::rc docs

c316ae5

Fixes rust-lang#29372.

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 21, 2016

Rollup merge of rust-lang#36571 - kmcallister:rust-langgh-29372-rc-do…

57c745d

…cs, r=GuillaumeGomez Tweak std::rc docs Fixes rust-lang#29372. r? @GuillaumeGomez

sophiajt mentioned this pull request Sep 21, 2016

Rollup of 9 pull requests #36635

Closed

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 22, 2016

Rollup merge of rust-lang#36571 - kmcallister:rust-langgh-29372-rc-do…

a86c83f

…cs, r=GuillaumeGomez Tweak std::rc docs Fixes rust-lang#29372. r? @GuillaumeGomez

sophiajt mentioned this pull request Sep 22, 2016

Rollup of 7 pull requests #36651

Merged

bors added a commit that referenced this pull request Sep 22, 2016

Auto merge of #36651 - jonathandturner:rollup, r=jonathandturner

4c04e36

Rollup of 7 pull requests - Successful merges: #36330, #36423, #36539, #36571, #36589, #36600, #36632 - Failed merges:

bors merged commit c316ae5 into rust-lang:master Sep 22, 2016

Uh oh!

Conversation

kmcallister commented Sep 18, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kmcallister commented Sep 19, 2016

Uh oh!

kmcallister commented Sep 21, 2016

Uh oh!

GuillaumeGomez commented Sep 21, 2016

Uh oh!

bors commented Sep 21, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants