Skip to content

run rustfmt on librustc_incremental folder#37346

Closed
srinivasreddy wants to merge 1 commit into
rust-lang:masterfrom
srinivasreddy:librustc_incremental
Closed

run rustfmt on librustc_incremental folder#37346
srinivasreddy wants to merge 1 commit into
rust-lang:masterfrom
srinivasreddy:librustc_incremental

Conversation

@srinivasreddy

@srinivasreddy srinivasreddy commented Oct 22, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Oct 22, 2016

Copy link
Copy Markdown
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@srinivasreddy

srinivasreddy commented Oct 22, 2016

Copy link
Copy Markdown
Contributor Author

@arielb1 LGTM. What do you think?

eddyb
eddyb reviewed Oct 22, 2016
View reviewed changes
Comment thread src/librustc_incremental/assert_dep_graph.rs Outdated

@eddyb eddyb Oct 22, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nrc @ubsan This looks harder to read.

@nrc nrc Oct 25, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is probably the trickiest corner of formatting at the moment - I prefer visual indent for method chains, but it makes closures either ugly or subject to extreme rightward drift.

@srinivasreddy

srinivasreddy commented Oct 28, 2016

Copy link
Copy Markdown
Contributor Author

r? @nrc

@rust-highfive rust-highfive assigned nrc and unassigned arielb1 Oct 28, 2016
@bors

bors commented Oct 31, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #37439) made this pull request unmergeable. Please resolve the merge conflicts.

@bors

bors commented Nov 3, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #37540) made this pull request unmergeable. Please resolve the merge conflicts.

@nrc

nrc commented Nov 7, 2016

Copy link
Copy Markdown
Member

r = me with a rebase

@frewsxcv

frewsxcv commented Nov 27, 2016

Copy link
Copy Markdown
Contributor

Closing due to inactivity. @srinivasreddy If you're still interested in these changes, let me know and I can reopen, otherwise you could just open a new PR.

@frewsxcv frewsxcv closed this Nov 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@eddyb eddyb eddyb left review comments

@nrc nrc nrc left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nrc nrc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@srinivasreddy @rust-highfive @bors @nrc @frewsxcv @eddyb @arielb1