Skip to content

instantiate closures on demand#37797

Merged
bors merged 1 commit into
rust-lang:masterfrom
arielb1:inline-closure
Nov 19, 2016
Merged

instantiate closures on demand#37797
bors merged 1 commit into
rust-lang:masterfrom
arielb1:inline-closure

Conversation

@arielb1

@arielb1 arielb1 commented Nov 16, 2016

Copy link
Copy Markdown
Contributor

this should fix compilation with -C codegen-units=4 - tested locally
with RUSTFLAGS='-C codegen-units=4' ../x.py test

r? @michaelwoerister

@michaelwoerister

Copy link
Copy Markdown
Member

@bors r+

Thanks, @arielb1!
I still think though that trans::callee::get_fn() should be fixed so that we have the option of not having a copy of closures in the using codegen unit.

@bors

bors commented Nov 16, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 52f7f13 has been approved by michaelwoerister

@arielb1

arielb1 commented Nov 16, 2016

Copy link
Copy Markdown
Contributor Author

@bors r=michaelwoerister

@bors

bors commented Nov 16, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 01fe235 has been approved by michaelwoerister

@bors

bors commented Nov 18, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #37660) made this pull request unmergeable. Please resolve the merge conflicts.

this should fix compilation with `-C codegen-units=4` - tested locally
with `RUSTFLAGS='-C codegen-units=4' ../x.py test`
@arielb1

arielb1 commented Nov 18, 2016

Copy link
Copy Markdown
Contributor Author

@bors r=michaelwoerister

@bors

bors commented Nov 18, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 4fc02f6 has been approved by michaelwoerister

@bors

bors commented Nov 19, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4fc02f6 with merge aa97daf...

bors added a commit that referenced this pull request Nov 19, 2016
instantiate closures on demand

this should fix compilation with `-C codegen-units=4` - tested locally
with `RUSTFLAGS='-C codegen-units=4' ../x.py test`

r? @michaelwoerister
@bors bors merged commit 4fc02f6 into rust-lang:master Nov 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants