Skip to content

Follow our own recommendations in the examples#38001

Merged
bors merged 1 commit into
rust-lang:masterfrom
vickenty:patch-1
Nov 26, 2016
Merged

Follow our own recommendations in the examples#38001
bors merged 1 commit into
rust-lang:masterfrom
vickenty:patch-1

Conversation

@vickenty

Copy link
Copy Markdown
Contributor

Remove exclamation marks from the the example error descriptions:

The description [...] should not contain newlines or sentence-ending punctuation

Remove exclamation marks from the the example error descriptions:
> The description [...] should not contain newlines or sentence-ending punctuation
@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@bluss

bluss commented Nov 25, 2016

Copy link
Copy Markdown
Contributor

@vickenty Thanks. I was just looking at this. Maybe it should also show somehow that Display can use formatting/interpolation when description does not, if there is a nice way to do that? It is a common question.

@steveklabnik

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

Thank you!

(I agree that @bluss 's suggestions sound good as well, if you or anyone else wants to send in another PR for that.)

@bors

bors commented Nov 25, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit a3ce398 has been approved by steveklabnik

sanxiyn added a commit to sanxiyn/rust that referenced this pull request Nov 26, 2016
Follow our own recommendations in the examples

Remove exclamation marks from the the example error descriptions:
> The description [...] should not contain newlines or sentence-ending punctuation
bors added a commit that referenced this pull request Nov 26, 2016
Rollup of 7 pull requests

- Successful merges: #37962, #37963, #37967, #37978, #37985, #38001, #38010
- Failed merges:
@bors bors merged commit a3ce398 into rust-lang:master Nov 26, 2016
@vickenty vickenty deleted the patch-1 branch November 26, 2016 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants