Skip to content

Rewrite, improve documentation for core::hash::BuildHasherDefault.#38334

Merged
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:BuildHasherDefault
Dec 19, 2016
Merged

Rewrite, improve documentation for core::hash::BuildHasherDefault.#38334
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:BuildHasherDefault

Conversation

@frewsxcv

@frewsxcv frewsxcv commented Dec 13, 2016

Copy link
Copy Markdown
Contributor

Fixes #31242.

@rust-highfive

rust-highfive commented Dec 13, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv

frewsxcv commented Dec 13, 2016

Copy link
Copy Markdown
Contributor Author

r? @rust-lang/docs

cc @rust-lang/libs to make sure I'm using BuildHasherDefault correctly here.

@frewsxcv frewsxcv mentioned this pull request Dec 13, 2016
Closed
@steveklabnik

steveklabnik commented Dec 13, 2016

Copy link
Copy Markdown
Contributor

@bors: delegate=kmcallister

@bors

bors commented Dec 13, 2016

Copy link
Copy Markdown
Collaborator

✌️ @kmcallister can now approve this pull request

@sfackler

sfackler commented Dec 13, 2016

Copy link
Copy Markdown
Member

LGTM

@GuillaumeGomez

GuillaumeGomez commented Dec 13, 2016

Copy link
Copy Markdown
Member

You even added all urls. T_T What a great day!

@bors: r+ rollup

@bors

bors commented Dec 13, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit ce1fbad has been approved by GuillaumeGomez

@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 15, 2016
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 15, 2016
@GuillaumeGomez
Rollup merge of rust-lang#38334 - frewsxcv:BuildHasherDefault, r=Guil…
24d2260 
…laumeGomez

Rewrite, improve documentation for `core::hash::BuildHasherDefault`.

Fixes rust-lang#31242.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 16, 2016
@GuillaumeGomez
Rollup merge of rust-lang#38334 - frewsxcv:BuildHasherDefault, r=Guil…
5f1f0e1 
…laumeGomez

Rewrite, improve documentation for `core::hash::BuildHasherDefault`.

Fixes rust-lang#31242.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 16, 2016
Closed
@bors

bors commented Dec 16, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit ce1fbad with merge 652b82e...

@bors

bors commented Dec 16, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-mac-64-opt-rustbuild

@frewsxcv

frewsxcv commented Dec 16, 2016

Copy link
Copy Markdown
Contributor Author

@bors retry

@bors

bors commented Dec 16, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit ce1fbad with merge d10ae8d...

@bors

bors commented Dec 16, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-mac-64-opt

@GuillaumeGomez

GuillaumeGomez commented Dec 16, 2016

Copy link
Copy Markdown
Member

@bors: retry

@oyvindln

oyvindln commented Dec 16, 2016

Copy link
Copy Markdown
Contributor

There is a failing doctest from this PR in the rollup #38407. Looks like there are some spelling issues.

@frewsxcv

frewsxcv commented Dec 16, 2016

Copy link
Copy Markdown
Contributor Author

@bors r-

@frewsxcv

frewsxcv commented Dec 16, 2016

Copy link
Copy Markdown
Contributor Author

@oyvindln Woops, thanks for letting me know! Spelling fixed in the latest force push.

@bors r=GuillaumeGomez rollup

@bors

bors commented Dec 16, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 17eac5d has been approved by GuillaumeGomez

@bors

bors commented Dec 16, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 17eac5d with merge 953b687...

@bors

bors commented Dec 16, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-mac-64-opt-rustbuild

@alexcrichton

alexcrichton commented Dec 16, 2016 via email

Copy link
Copy Markdown
Member

@frewsxcv

frewsxcv commented Dec 16, 2016

Copy link
Copy Markdown
Contributor Author

Travis found another typo.

@bors r=GuillaumeGomez

@bors

bors commented Dec 16, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit d409fc3 has been approved by GuillaumeGomez

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 18, 2016
@GuillaumeGomez
Rollup merge of rust-lang#38334 - frewsxcv:BuildHasherDefault, r=Guil…
ca8f287 
…laumeGomez

Rewrite, improve documentation for `core::hash::BuildHasherDefault`.

Fixes rust-lang#31242.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 18, 2016
Closed
sanxiyn added a commit to sanxiyn/rust that referenced this pull request Dec 19, 2016
@sanxiyn
Rollup merge of rust-lang#38334 - frewsxcv:BuildHasherDefault, r=Guil…
86cf922 
…laumeGomez

Rewrite, improve documentation for `core::hash::BuildHasherDefault`.

Fixes rust-lang#31242.
@sanxiyn sanxiyn mentioned this pull request Dec 19, 2016
Merged
bors added a commit that referenced this pull request Dec 19, 2016
@bors
Auto merge of #38466 - sanxiyn:rollup, r=sanxiyn
10271ea 
Rollup of 9 pull requests

- Successful merges: #38334, #38397, #38413, #38421, #38422, #38433, #38438, #38445, #38459
- Failed merges:
@bors bors merged commit d409fc3 into rust-lang:master Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@frewsxcv @rust-highfive @steveklabnik @bors @sfackler @GuillaumeGomez @oyvindln @alexcrichton @aturon