Skip to content

Improvements to 'include' macro documentation.#38457

Merged
bors merged 3 commits into
rust-lang:masterfrom
frewsxcv:include
Jan 19, 2017
Merged

Improvements to 'include' macro documentation.#38457
bors merged 3 commits into
rust-lang:masterfrom
frewsxcv:include

Conversation

@frewsxcv

Copy link
Copy Markdown
Contributor

No description provided.

@frewsxcv

frewsxcv commented Dec 18, 2016

Copy link
Copy Markdown
Contributor Author

I'm open to a different example if someone has a better idea.

@frewsxcv

Copy link
Copy Markdown
Contributor Author

@bors delegate=kmcallister

@bors

bors commented Dec 18, 2016

Copy link
Copy Markdown
Collaborator

✌️ @kmcallister can now approve this pull request

@durka durka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's worth including a warning about #35560? (i.e. don't include! a file with more than one statement in it)

Comment thread src/libstd/macros.rs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pedantically, I guess it will actually print "Hello World!"

Comment thread src/libstd/macros.rs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well fix the small typo on the next line (should be "unhygienically")

@frewsxcv

Copy link
Copy Markdown
Contributor Author

@durka Thanks for the feedback! Comments have been addressed.

@frewsxcv

Copy link
Copy Markdown
Contributor Author

r? @GuillaumeGomez

@GuillaumeGomez

Copy link
Copy Markdown
Member

Thanks for the examples and the fixes!

@bors: r+ rollup

@bors

bors commented Jan 17, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 4a354ab has been approved by GuillaumeGomez

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 19, 2017
Improvements to 'include' macro documentation.

None
bors added a commit that referenced this pull request Jan 19, 2017
Rollup of 11 pull requests

- Successful merges: #38457, #38922, #38970, #39039, #39091, #39115, #39121, #39149, #39150, #39151, #39165
- Failed merges:
@bors bors merged commit 4a354ab into rust-lang:master Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants