travis: Start uploading artifacts on commits#38748
Conversation
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Shouldn't this be before_deploy? (like Travis)
There was a problem hiding this comment.
Weird I thought this didn't exist... I'll change it!
There was a problem hiding this comment.
Oh wait right we can't do that because otherwise the artifacts listing on AppVeyor fails. Those artifacts have to be in place before the deploy (and before_deploy) step starts I believe.
There was a problem hiding this comment.
Yeah, I have seen that too but you can Push-AppveyorArtifact the artifacts in the before_deploy phase. You still have to declare them in appveyor.yml though but a glob works.
There was a problem hiding this comment.
I am concerned about this after_test stuff running on all AppVeyor build jobs rathern than only on those that are going to be "deployed".
|
☔ The latest upstream changes (presumably #38731) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Ok I've rebased and updated how AppVeyor uploads. r? @brson |
There was a problem hiding this comment.
Nit: single square brackets should use =. Otherwise use [[ to make it clear bash is required.
|
@bors r+ |
|
📌 Commit 4c94686 has been approved by |
|
⌛ Testing commit 4c94686 with merge 4dea79d... |
|
💔 Test failed - status-travis |
|
@bors: r=brson |
|
📌 Commit be31abb has been approved by |
|
⌛ Testing commit be31abb with merge c938a03... |
|
💔 Test failed - status-travis |
|
@bors: r=brson |
|
📌 Commit 7ff6b67 has been approved by |
|
⌛ Testing commit 7ff6b67 with merge 9d2a338... |
|
💔 Test failed - status-travis |
|
@bors: r=brson |
|
📌 Commit 7cf8dee has been approved by |
|
⌛ Testing commit 7cf8dee with merge 236a18a... |
|
📌 Commit 5e40c5b has been approved by |
|
⌛ Testing commit 5e40c5b with merge 8d43b96... |
|
💔 Test failed - status-travis |
|
… On Tue, Jan 10, 2017 at 9:26 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/190837787>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#38748 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95HZHnAHn5cRKQ_TNs9eFhSGNwq9Uks5rRGgQgaJpZM4LYpjc>
.
|
|
⌛ Testing commit 5e40c5b with merge ac67e1f... |
|
💔 Test failed - status-appveyor |
|
@bors: r=brson |
|
📌 Commit 5d52402 has been approved by |
|
⌛ Testing commit 5d52402 with merge efeca8f... |
|
💔 Test failed - status-travis |
|
… On Wed, Jan 11, 2017 at 4:21 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/191145763>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#38748 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95Kt1CiCy4DYqKDCYsj9zs7rSgMIwks5rRXITgaJpZM4LYpjc>
.
|
|
⌛ Testing commit 5d52402 with merge 0b93364... |
travis: Start uploading artifacts on commits This commit starts adding the infrastructure for uploading release artifacts from AppVeyor/Travis on each commit. The idea is that eventually we'll upload a full release to AppVeyor/Travis in accordance with plans [outlined earlier]. Right now this configures Travis/Appveyor to upload all tarballs in the `dist` directory, and various images are updated to actually produce tarballs in these directories. These are nowhere near ready to be actual release artifacts, but this should allow us to play around with it and test it out. Once this commit lands we should start seeing artifacts uploaded on each commit. [outlined earlier]: https://internals.rust-lang.org/t/rust-ci-release-infrastructure-changes/4489
|
💔 Test failed - status-travis |
This commit starts adding the infrastructure for uploading release artifacts from AppVeyor/Travis on each commit. The idea is that eventually we'll upload a full release to AppVeyor/Travis in accordance with plans [outlined earlier]. Right now this configures Travis/Appveyor to upload all tarballs in the `dist` directory, and various images are updated to actually produce tarballs in these directories. These are nowhere near ready to be actual release artifacts, but this should allow us to play around with it and test it out. Once this commit lands we should start seeing artifacts uploaded on each commit. [outlined earlier]: https://internals.rust-lang.org/t/rust-ci-release-infrastructure-changes/4489
|
@bors: r=brson |
|
📌 Commit 3187672 has been approved by |
|
⌛ Testing commit 3187672 with merge 927c55d... |
travis: Start uploading artifacts on commits This commit starts adding the infrastructure for uploading release artifacts from AppVeyor/Travis on each commit. The idea is that eventually we'll upload a full release to AppVeyor/Travis in accordance with plans [outlined earlier]. Right now this configures Travis/Appveyor to upload all tarballs in the `dist` directory, and various images are updated to actually produce tarballs in these directories. These are nowhere near ready to be actual release artifacts, but this should allow us to play around with it and test it out. Once this commit lands we should start seeing artifacts uploaded on each commit. [outlined earlier]: https://internals.rust-lang.org/t/rust-ci-release-infrastructure-changes/4489
|
☀️ Test successful - status-appveyor, status-travis |
6 participants
This commit starts adding the infrastructure for uploading release artifacts
from AppVeyor/Travis on each commit. The idea is that eventually we'll upload a
full release to AppVeyor/Travis in accordance with plans outlined earlier.
Right now this configures Travis/Appveyor to upload all tarballs in the
distdirectory, and various images are updated to actually produce tarballs in these
directories. These are nowhere near ready to be actual release artifacts, but
this should allow us to play around with it and test it out. Once this commit
lands we should start seeing artifacts uploaded on each commit.