Skip to content

[Gate Tests] - marking feature tests#39250

Merged
bors merged 1 commit into
rust-lang:masterfrom
cseale:issue_30924
Jan 31, 2017
Merged

[Gate Tests] - marking feature tests#39250
bors merged 1 commit into
rust-lang:masterfrom
cseale:issue_30924

Conversation

@cseale

@cseale cseale commented Jan 22, 2017

Copy link
Copy Markdown
Contributor

Removal of the lang feature gate tests whitelist #39059

r? @est31

@est31

est31 commented Jan 23, 2017

Copy link
Copy Markdown
Member

Thanks!

As I said in #39059 we need to wait until #39247 is merged (+ then you'll have to rebase), as it requires searching inside compile-fail-fulldeps to be implemented.

@cseale

cseale commented Jan 23, 2017

Copy link
Copy Markdown
Contributor Author

np

@est31

est31 commented Jan 23, 2017

Copy link
Copy Markdown
Member

@cseale the PR got merged.

@bors

bors commented Jan 26, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #39075) made this pull request unmergeable. Please resolve the merge conflicts.

Comment thread src/tools/tidy/src/features.rs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was "reflect" added here?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was removed by #39075, so shouldn't be present.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaned this up

Comment thread src/tools/tidy/src/features.rs Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got a trailing whitespace here, that's why tidy fails.

@jseyfried

Copy link
Copy Markdown
Contributor

@bors delegate=est31

@bors

bors commented Jan 29, 2017

Copy link
Copy Markdown
Collaborator

✌️ @est31 can now approve this pull request

Removal of the lang feature gate tests whitelist rust-lang#39059

r? @est31
@est31

est31 commented Jan 31, 2017

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jan 31, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 94e9086 has been approved by est31

@bors

bors commented Jan 31, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 94e9086 with merge b854d74...

bors added a commit that referenced this pull request Jan 31, 2017
[Gate Tests] - marking feature tests

Removal of the lang feature gate tests whitelist #39059

r? @est31
@bors

bors commented Jan 31, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: est31
Pushing b854d74 to master...

@bors bors merged commit 94e9086 into rust-lang:master Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants