[beta] Another round of backporting PRs to beta#39750
Merged
Merged
Conversation
Prevents stale artifacts from sticking around by accident!
The current manifests encode this with a dash in the name, so we should preserve that!
Right now we just run `shasum` on an absolute path but right now the shasum files only include filenames, so let's use `current_dir` and just the file name to only have the file name emitted.
The previous fix contained an error where `toml::encode` returned a runtime error, so this version just constructs a literal `toml::Value`.
Contributor
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
|
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 78c2148 has been approved by |
Member
Author
|
@bors: r=brson (adding a beta version bump to this PR) |
Collaborator
|
📌 Commit f51adf9 has been approved by |
1 similar comment
Collaborator
|
📌 Commit f51adf9 has been approved by |
Collaborator
Collaborator
|
💔 Test failed - status-travis |
Member
Author
|
@bors: retry
|
Member
Author
|
… On Wed, Feb 15, 2017 at 7:48 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/201857610>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39750 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95OUdhYVsNkGb5ZSBKxz6TbdobJoBks5rcwIYgaJpZM4L-Ue1>
.
|
Collaborator
|
⌛ Testing commit f51adf9 with merge 8e248d0... |
Collaborator
|
💔 Test failed - status-travis |
Member
Author
|
… On Wed, Feb 15, 2017 at 4:02 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/202001941>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39750 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95MGxtIiMF9IB4XiTvDy9lw5h8C9Pks5rc3XjgaJpZM4L-Ue1>
.
|
Collaborator
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of the following PRs:
make clean#39622