Skip to content

Add a test that -fPIC is applied#39803

Merged
bors merged 2 commits into
rust-lang:masterfrom
brson:fpic
Mar 2, 2017
Merged

Add a test that -fPIC is applied#39803
bors merged 2 commits into
rust-lang:masterfrom
brson:fpic

Conversation

@brson

@brson brson commented Feb 14, 2017

Copy link
Copy Markdown
Contributor

r? @alexcrichton Can it really be this simple? I've tested it works, but still testing that it used to fail.

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

Let's find out!

@bors

bors commented Feb 14, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 9cad324 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 14, 2017
Add a test that -fPIC is applied

r? @alexcrichton Can it really be this simple? I've tested it works, but still testing that it used to fail.
@frewsxcv

Copy link
Copy Markdown
Contributor

@brson

brson commented Feb 15, 2017

Copy link
Copy Markdown
Contributor Author

comparing UNAME to Windows is bogus

@brson

brson commented Feb 15, 2017

Copy link
Copy Markdown
Contributor Author

@bors r=alexcrichton

Picked a different env var.

@bors

bors commented Feb 15, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit e77f856 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 16, 2017
Add a test that -fPIC is applied

r? @alexcrichton Can it really be this simple? I've tested it works, but still testing that it used to fail.
@bors

bors commented Feb 16, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e77f856 with merge be9f0bf...

@bors

bors commented Feb 16, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@alexcrichton

alexcrichton commented Feb 16, 2017 via email

Copy link
Copy Markdown
Member

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 16, 2017
Add a test that -fPIC is applied

r? @alexcrichton Can it really be this simple? I've tested it works, but still testing that it used to fail.
@bors

bors commented Feb 17, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e77f856 with merge f5f6207...

@bors

bors commented Feb 17, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Mar 1, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 55dab70 has been approved by alexcrichton

@bors

bors commented Mar 1, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 55dab70 with merge f5635fa...

bors added a commit that referenced this pull request Mar 1, 2017
Add a test that -fPIC is applied

r? @alexcrichton Can it really be this simple? I've tested it works, but still testing that it used to fail.
@bors

bors commented Mar 1, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@alexcrichton

alexcrichton commented Mar 1, 2017 via email

Copy link
Copy Markdown
Member

@bors

bors commented Mar 1, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 55dab70 with merge d095437...

bors added a commit that referenced this pull request Mar 1, 2017
Add a test that -fPIC is applied

r? @alexcrichton Can it really be this simple? I've tested it works, but still testing that it used to fail.
@bors

bors commented Mar 2, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing d095437 to master...

@bors bors merged commit 55dab70 into rust-lang:master Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants