Skip to content

Added test for inclusive_range_syntax in compile-fail test suite#40031

Merged
bors merged 1 commit into
rust-lang:masterfrom
nikhilshagri:master
Feb 25, 2017
Merged

Added test for inclusive_range_syntax in compile-fail test suite#40031
bors merged 1 commit into
rust-lang:masterfrom
nikhilshagri:master

Conversation

@nikhilshagri

Copy link
Copy Markdown
Contributor

Fixes #39059
r? @est31

Forgot to leave a comment on the issue, hopefully nobody else is working on this one!

@durka

durka commented Feb 22, 2017

Copy link
Copy Markdown
Contributor

This is already tested at src/test/parse-fail/range_inclusive_gate.rs.

@est31

est31 commented Feb 22, 2017

Copy link
Copy Markdown
Member

@durka thanks for pointing this out! Seems I've missed that test when generating the list for #39059.

@cynicaldevil you should instead of adding the test add the // gate-test-... comment and add the test/parse-fail directory to the list of directories with feature gate tests inside so that its recognized.

@nikhilshagri

Copy link
Copy Markdown
Contributor Author

@est31 Updated PR.

@jseyfried

Copy link
Copy Markdown
Contributor

@bors delegate=est31

@bors

bors commented Feb 22, 2017

Copy link
Copy Markdown
Collaborator

✌️ @est31 can now approve this pull request

@est31

est31 commented Feb 22, 2017

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Feb 22, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit b7b58ff has been approved by est31

@eddyb

eddyb commented Feb 25, 2017

Copy link
Copy Markdown
Contributor

@bors rollup

eddyb added a commit to eddyb/rust that referenced this pull request Feb 25, 2017
Added test for inclusive_range_syntax in compile-fail test suite

Fixes rust-lang#39059
r? @est31

Forgot to leave a comment on the issue, hopefully nobody else is working on this one!
eddyb added a commit to eddyb/rust that referenced this pull request Feb 25, 2017
Added test for inclusive_range_syntax in compile-fail test suite

Fixes rust-lang#39059
r? @est31

Forgot to leave a comment on the issue, hopefully nobody else is working on this one!
bors added a commit that referenced this pull request Feb 25, 2017
@bors bors merged commit b7b58ff into rust-lang:master Feb 25, 2017
@est31

est31 commented Feb 25, 2017

Copy link
Copy Markdown
Member

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants