[beta] next by brson · Pull Request #40046 · rust-lang/rust

brson · 2017-02-23T03:02:35Z

@nikomatsakis this commit did not pick cleanly. You might peek at it.

I took the liberty of accepting all the nominations myself, but the packed struct alignment PR is quite large. It did pick fine though and there's a comment there suggesting it works on beta cc @rust-lang/compiler.

cc @alexcrichton

These are some samples that I have been focusing on improving over time. In this PR, I mainly want to stem the bleeding where we in some cases we show an error that gives you no possible way to divine the problem.

According to the LLVM reference: > A value of 0 or an omitted align argument means that the operation has the ABI alignment for the target. So loads/stores of fields of packed structs need to have their align set to 1. Implement that by tracking the alignment of `LvalueRef`s. Fixes rust-lang#39376.

The function was a footgun because it created `undef` references to ZSTs, which could cause trouble were they to leak to user code.

…igured

rust-highfive · 2017-02-23T03:02:47Z

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2017-02-23T03:02:48Z

Warning

Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

alexcrichton · 2017-02-23T04:11:01Z

@bors: r+

bors · 2017-02-23T04:11:02Z

📌 Commit e7235d3 has been approved by alexcrichton

alexcrichton · 2017-02-23T04:11:16Z

@bors: p=1

(beta branch_

bors · 2017-02-23T06:02:58Z

⌛ Testing commit e7235d3 with merge a925124...

bors · 2017-02-23T06:12:07Z

💔 Test failed - status-travis

alexcrichton · 2017-02-23T15:19:12Z

@bors: retry * network error

…

On Thu, Feb 23, 2017 at 12:12 AM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/204479279> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#40046 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95OmHMXGD9RwNLVriGZMfWPN8MgVdks5rfSM4gaJpZM4MJe-_> .

nikomatsakis · 2017-02-23T20:15:10Z

@brson diff looks ok to me re: that commit

bors · 2017-02-24T00:04:39Z

⌛ Testing commit e7235d3 with merge da59c36...

bors · 2017-02-24T02:02:05Z

💔 Test failed - status-travis

alexcrichton · 2017-02-24T04:27:53Z

@bors: retry * android bot ran out of disk space?

…

On Thu, Feb 23, 2017 at 8:02 PM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/204801768> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#40046 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95AYDZg6rOFMpmK1GLyj5PDS-QFvlks5rfjoegaJpZM4MJe-_> .

alexcrichton · 2017-02-26T05:33:24Z

@bors: retry * network failure

…

On Sat, Feb 25, 2017 at 10:34 PM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/205433364> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#40046 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95EORdBZojqe5wc8RgCqV3XWEKnBMks5rgQDCgaJpZM4MJe-_> .

bors · 2017-02-26T11:07:24Z

⌛ Testing commit 625f598 with merge 6a56824...

bors · 2017-02-26T12:58:06Z

💔 Test failed - status-travis

eddyb · 2017-02-26T13:00:30Z

mkdir: cannot create directory ‘deploy’: No space left on device

alexcrichton · 2017-02-27T23:06:47Z

Attempting to handle in #40135

PRs can't land againt beta right now because the android bot is filling up on disk space. I don't really know what's going on but the android bot is the longest one to run anyway so it'll benefit from being split up regardless.

alexcrichton · 2017-02-28T16:41:20Z

@bors: r+

bors · 2017-02-28T16:41:21Z

📌 Commit f0477b2 has been approved by alexcrichton

bors · 2017-02-28T17:31:06Z

⌛ Testing commit f0477b2 with merge 5fee06b...

alexcrichton · 2017-02-28T18:30:29Z

@bors: retry

bors · 2017-02-28T18:44:58Z

💔 Test failed - status-travis

bors · 2017-02-28T19:12:59Z

⌛ Testing commit f0477b2 with merge 8c56af1...

bors · 2017-02-28T19:19:44Z

💔 Test failed - status-appveyor

alexcrichton · 2017-02-28T22:28:41Z

@bors: retry * network error

…

On Tue, Feb 28, 2017 at 1:19 PM, bors ***@***.***> wrote: 💔 Test failed - status-appveyor <https://ci.appveyor.com/project/rust-lang/rust/build/1.0.2161> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#40046 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95KeJjiM5B_s7IXOWT5oxSycvbc3nks5rhHNSgaJpZM4MJe-_> .

bors · 2017-02-28T23:30:26Z

⌛ Testing commit f0477b2 with merge 68f8347...

bors · 2017-03-01T00:58:07Z

💔 Test failed - status-travis

alexcrichton · 2017-03-01T18:47:42Z

@bors: retry

nothing failed?

bors · 2017-03-01T20:10:37Z

⌛ Testing commit f0477b2 with merge 9c10139...

bors · 2017-03-01T22:16:05Z

💔 Test failed - status-travis

alexcrichton · 2017-03-01T22:30:40Z

My guess is that it's yet another spurious failure, but I can't read the logs, so I'll wait to find out.

alexcrichton · 2017-03-01T23:46:48Z

@bors: retry * osx linker segfault #39003

…

On Wed, Mar 1, 2017 at 4:16 PM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/206744191> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#40046 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95JPDsTW40WdH5vC9xSMsB9HXtF9Oks5rhe4qgaJpZM4MJe-_> .

bors · 2017-03-02T01:19:48Z

⌛ Testing commit f0477b2 with merge ecbf0b5...

@nikomatsakis

[beta] next - #39913 - #39730 - #39674 - #39602 - #39586 - #39471 - #39980 - #40020 - #40135 @nikomatsakis [this commit](3787d33) did not pick cleanly. You might peek at it. I took the liberty of accepting all the nominations myself, but the [packed struct alignment](#39586) PR is quite large. It did pick fine though and there's a comment there suggesting it works on beta cc @rust-lang/compiler. cc @alexcrichton

bors · 2017-03-02T03:34:48Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing ecbf0b5 to beta...

nikomatsakis and others added 15 commits February 23, 2017 02:21

add some sample UI error test cases

6f405bc

These are some samples that I have been focusing on improving over time. In this PR, I mainly want to stem the bleeding where we in some cases we show an error that gives you no possible way to divine the problem.

remove vestiges of the old suggestion machinery

3787d33

fix run-pass test that required Copy impl

8b08e61

Fix ICE on certain sequence repetitions.

6e7cdf1

Fix ICE when parsing token trees after an error.

68e715c

Fix ICE when accessing mutably an immutable enum

c7edd20

remove unneeded drop of isize

eda6e6f

Inline the function with_lvalue_ref into trans_transmute

962c4d9

The function was a footgun because it created `undef` references to ZSTs, which could cause trouble were they to leak to user code.

address review comments

c835579

pacify tidy

e68c621

Don't check for sudo environment if vendored sources are already conf…

9975684

…igured

Guard against USER not existing in the environment

e671f19

Fix typo in bootstrap.py info message

8d52183

Bump prerelease version

e7235d3

rust-highfive assigned pnkfelix Feb 23, 2017

travis: Split Android into dist/test images

f0477b2

PRs can't land againt beta right now because the android bot is filling up on disk space. I don't really know what's going on but the android bot is the longest one to run anyway so it'll benefit from being split up regardless.

bors merged commit f0477b2 into rust-lang:beta Mar 2, 2017

Uh oh!

Conversation

brson commented Feb 23, 2017 • edited by alexcrichton Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Feb 23, 2017

Uh oh!

rust-highfive commented Feb 23, 2017

Uh oh!

alexcrichton commented Feb 23, 2017

Uh oh!

bors commented Feb 23, 2017

Uh oh!

alexcrichton commented Feb 23, 2017

Uh oh!

bors commented Feb 23, 2017

Uh oh!

bors commented Feb 23, 2017

Uh oh!

alexcrichton commented Feb 23, 2017 via email

Uh oh!

nikomatsakis commented Feb 23, 2017

Uh oh!

bors commented Feb 24, 2017

Uh oh!

bors commented Feb 24, 2017

Uh oh!

alexcrichton commented Feb 24, 2017 via email

Uh oh!

alexcrichton commented Feb 26, 2017 via email

Uh oh!

bors commented Feb 26, 2017

Uh oh!

bors commented Feb 26, 2017

Uh oh!

eddyb commented Feb 26, 2017

Uh oh!

alexcrichton commented Feb 27, 2017

Uh oh!

alexcrichton commented Feb 28, 2017

Uh oh!

bors commented Feb 28, 2017

Uh oh!

bors commented Feb 28, 2017

Uh oh!

alexcrichton commented Feb 28, 2017

Uh oh!

bors commented Feb 28, 2017

Uh oh!

bors commented Feb 28, 2017

Uh oh!

bors commented Feb 28, 2017

Uh oh!

alexcrichton commented Feb 28, 2017 via email

Uh oh!

bors commented Feb 28, 2017

Uh oh!

bors commented Mar 1, 2017

Uh oh!

alexcrichton commented Mar 1, 2017

Uh oh!

bors commented Mar 1, 2017

Uh oh!

bors commented Mar 1, 2017

Uh oh!

alexcrichton commented Mar 1, 2017

Uh oh!

alexcrichton commented Mar 1, 2017 via email

Uh oh!

bors commented Mar 2, 2017

Uh oh!

bors commented Mar 2, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

brson commented Feb 23, 2017 •

edited by alexcrichton

Loading