Skip to content

rustbuild: Retry downloads by default#40060

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:retry-downloads
Feb 25, 2017
Merged

rustbuild: Retry downloads by default#40060
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:retry-downloads

Conversation

@alexcrichton

@alexcrichton alexcrichton commented Feb 23, 2017

Copy link
Copy Markdown
Member

Don't rely on curl's --retry, it appears to not work for some errors like SSL
errors.

@alexcrichton
rustbuild: Retry downloads by default
30b0ed0 
Don't rely on curl's --retry, it appears to not work for some errors like SSL
errors.
@rust-highfive

rust-highfive commented Feb 23, 2017

Copy link
Copy Markdown
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@aturon

aturon commented Feb 23, 2017

Copy link
Copy Markdown
Contributor

@bors: r+

@bors

bors commented Feb 23, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 30b0ed0 has been approved by aturon

@frewsxcv

frewsxcv commented Feb 23, 2017

Copy link
Copy Markdown
Contributor

This is tangential to your PR, but is there any way to prevent this from happening? https://travis-ci.org/rust-lang/rust/jobs/204633420 It was just stalling for 30 minutes due to, presumably, network issues

@alexcrichton

alexcrichton commented Feb 23, 2017

Copy link
Copy Markdown
Member Author

Unfortunately not that I know of, that was likely cloning just at a really slow rate

@frewsxcv

frewsxcv commented Feb 24, 2017

Copy link
Copy Markdown
Contributor

@bors p=15

@frewsxcv

frewsxcv commented Feb 24, 2017

Copy link
Copy Markdown
Contributor

@bors p=7

@bors

bors commented Feb 24, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 30b0ed0 with merge ec9eca5...

@bors

bors commented Feb 24, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@frewsxcv

frewsxcv commented Feb 24, 2017

Copy link
Copy Markdown
Contributor

@bors retry

@bors

bors commented Feb 24, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 30b0ed0 with merge a3b807d...

@bors

bors commented Feb 24, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@frewsxcv

frewsxcv commented Feb 24, 2017

Copy link
Copy Markdown
Contributor

@bors retry

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 24, 2017
@frewsxcv
Rollup merge of rust-lang#40060 - alexcrichton:retry-downloads, r=aturon
1166995 
rustbuild: Retry downloads by default

Don't rely on curl's --retry, it appears to not work for some errors like SSL
errors.
@frewsxcv frewsxcv mentioned this pull request Feb 24, 2017
Closed
bors added a commit that referenced this pull request Feb 24, 2017
@bors
Auto merge of #40080 - frewsxcv:rollup, r=frewsxcv
c9d3749 
Rollup of 17 pull requests

- Successful merges: #39777, #39815, #39845, #39886, #39892, #39903, #39905, #39914, #39927, #39940, #40010, #40030, #40048, #40050, #40052, #40060, #40071
- Failed merges:
@bors

bors commented Feb 24, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 30b0ed0 with merge 14061ce...

bors added a commit that referenced this pull request Feb 24, 2017
@bors
Auto merge of #40060 - alexcrichton:retry-downloads, r=aturon
14061ce 
rustbuild: Retry downloads by default

Don't rely on curl's --retry, it appears to not work for some errors like SSL
errors.
@arielb1

arielb1 commented Feb 24, 2017

Copy link
Copy Markdown
Contributor

Note: both travis failures are #39003.

@bors

bors commented Feb 24, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@alexcrichton

alexcrichton commented Feb 24, 2017 via email

Copy link
Copy Markdown
Member Author

@bors

bors commented Feb 25, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 30b0ed0 with merge e78aa5d...

bors added a commit that referenced this pull request Feb 25, 2017
@bors
Auto merge of #40060 - alexcrichton:retry-downloads, r=aturon
e78aa5d 
rustbuild: Retry downloads by default

Don't rely on curl's --retry, it appears to not work for some errors like SSL
errors.
@bors

bors commented Feb 25, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing e78aa5d to master...

@bors bors merged commit 30b0ed0 into rust-lang:master Feb 25, 2017
@alexcrichton alexcrichton deleted the retry-downloads branch March 8, 2017 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aturon aturon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alexcrichton @rust-highfive @aturon @bors @frewsxcv @arielb1