Skip to content

Add compile fail test for SIMD#40101

Merged
bors merged 1 commit into
rust-lang:masterfrom
danobi:feat_gate_test_simd
Mar 3, 2017
Merged

Add compile fail test for SIMD#40101
bors merged 1 commit into
rust-lang:masterfrom
danobi:feat_gate_test_simd

Conversation

@danobi

@danobi danobi commented Feb 25, 2017

Copy link
Copy Markdown
Contributor

This completes the missing SIMD test task for issue #39059.

@rust-highfive

rust-highfive commented Feb 25, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton

alexcrichton commented Feb 25, 2017

Copy link
Copy Markdown
Member

@bors: r+

Looks great, thanks!

@bors

bors commented Feb 25, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 9e51958 has been approved by alexcrichton

@frewsxcv frewsxcv mentioned this pull request Feb 26, 2017
Closed
@bors

bors commented Feb 26, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9e51958 with merge c76fabf...

@bors

bors commented Feb 26, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@alexcrichton

alexcrichton commented Feb 26, 2017 via email

Copy link
Copy Markdown
Member

@bors

bors commented Feb 26, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9e51958 with merge ac0b2ad...

@bors

bors commented Feb 26, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@alexcrichton

alexcrichton commented Feb 26, 2017 via email

Copy link
Copy Markdown
Member

@est31 est31 mentioned this pull request Feb 27, 2017
Closed
20 tasks
@aturon

aturon commented Feb 28, 2017

Copy link
Copy Markdown
Contributor

@bors: retry

@aturon

aturon commented Feb 28, 2017

Copy link
Copy Markdown
Contributor

@bors: r=alexcrichton

@bors

bors commented Feb 28, 2017

Copy link
Copy Markdown
Collaborator

💡 This pull request was already approved, no need to approve it again.

@bors

bors commented Feb 28, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 9e51958 has been approved by alexcrichton

@eddyb eddyb mentioned this pull request Feb 28, 2017
Closed
@frewsxcv frewsxcv mentioned this pull request Feb 28, 2017
Merged
bors added a commit that referenced this pull request Feb 28, 2017
@bors
Auto merge of #40148 - frewsxcv:rollup, r=frewsxcv
be76056 
Rollup of 9 pull requests

- Successful merges: #39977, #40033, #40047, #40056, #40057, #40122, #40124, #40126, #40131
- Failed merges: #40101
@bors

bors commented Feb 28, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #40148) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton

alexcrichton commented Mar 2, 2017

Copy link
Copy Markdown
Member

@danobi want to rebase this to r+ again?

@danobi danobi force-pushed the feat_gate_test_simd branch from 9e51958 to dc53e56 Compare March 3, 2017 00:40
@danobi

danobi commented Mar 3, 2017

Copy link
Copy Markdown
Contributor Author

Done

@alexcrichton

alexcrichton commented Mar 3, 2017

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Mar 3, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit dc53e56 has been approved by alexcrichton

@bors

bors commented Mar 3, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit dc53e56 with merge b1e3176...

bors added a commit that referenced this pull request Mar 3, 2017
@bors
Auto merge of #40101 - danobi:feat_gate_test_simd, r=alexcrichton
b1e3176 
Add compile fail test for SIMD

This completes the missing SIMD test task for issue #39059.
@bors

bors commented Mar 3, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing b1e3176 to master...

@bors bors merged commit dc53e56 into rust-lang:master Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichton alexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@danobi @rust-highfive @alexcrichton @bors @aturon