Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
6ba494b
Point to let when modifying field of immutable variable
estebank Mar 11, 2017
38b5b29
Change label to "consider changing this to `mut f`"
estebank Mar 12, 2017
9ac628d
Add label to primary span for mutable access of immutable struct error
estebank Mar 13, 2017
b43c744
Add feature toggle for rvalue-static-promotion RFC
tbg Mar 11, 2017
20c0f32
Use `&&` instead of `&`
tbg Mar 12, 2017
f06b049
Improve the documentation for `rvalue_static_promotion`
tbg Mar 12, 2017
befeb04
Remove unused param from bootstrap::clean::rm_rf
mbrubeck Mar 15, 2017
9b89274
Fix const not displayed in rustdoc
GuillaumeGomez Mar 16, 2017
910532e
Add a test for issue 34571
topecongiro Mar 16, 2017
50cede0
documented order of conversion between u32 an ipv4addr
Mar 17, 2017
963d4df
minor wording tweak to slice::{as_ptr, as_mut_ptr}
QuietMisdreavus Mar 17, 2017
ec8ecf4
Fix typo in mutex.rs docs
ScottAbbey Mar 17, 2017
cb96ade
Fix regression when `include!()`ing a `macro_rules!` containing a `$c…
jseyfried Mar 16, 2017
2976ddb
Fix a spelling error in HashMap documentation, and slightly reword it…
jswalden Mar 18, 2017
8eaac08
Parse 0e+10 as a valid floating-point literal
topecongiro Mar 17, 2017
b77d31a
Add mention of None as possible return. Closes #40435.
russmack Mar 19, 2017
7add53e
Fix a typo in path.rs docs
s3rvac Mar 19, 2017
7b686ce
Rollup merge of #40441 - tschottdorf:promotable-rfc, r=eddyb
frewsxcv Mar 19, 2017
9032cea
Rollup merge of #40445 - estebank:issue-18150, r=jonathandturner
frewsxcv Mar 19, 2017
8287d0d
Rollup merge of #40562 - mbrubeck:bootstrap, r=alexcrichton
frewsxcv Mar 19, 2017
a04c7de
Rollup merge of #40564 - GuillaumeGomez:rustdoc-const, r=frewsxcv
frewsxcv Mar 19, 2017
c949f49
Rollup merge of #40583 - jseyfried:fix_include_macro_regression, r=nrc
frewsxcv Mar 19, 2017
03a30b5
Rollup merge of #40588 - topecongiro:add-missing-tests, r=alexcrichton
frewsxcv Mar 19, 2017
f2290da
Rollup merge of #40589 - topecongiro:floating-point-literal, r=nagisa
frewsxcv Mar 19, 2017
d74c528
Rollup merge of #40590 - z1mvader:master, r=steveklabnik
frewsxcv Mar 19, 2017
969e625
Rollup merge of #40603 - QuietMisdreavus:slice-ptr-docs, r=GuillaumeG…
frewsxcv Mar 19, 2017
d8c8e01
Rollup merge of #40611 - ScottAbbey:patch-1, r=GuillaumeGomez
frewsxcv Mar 19, 2017
9e11ecb
Rollup merge of #40621 - jswalden:dependant-spelling-fix, r=sfackler
frewsxcv Mar 19, 2017
35cf2f9
Rollup merge of #40646 - russmack:issue-40435-mention-none, r=frewsxcv
frewsxcv Mar 19, 2017
94e346b
Rollup merge of #40648 - s3rvac:fix-path-docs-typo, r=frewsxcv
frewsxcv Mar 19, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change label to "consider changing this to mut f"
Change the wording of mutable borrow on immutable binding from "this
should be `mut`" to "consider changing this to `mut f`".
  • Loading branch information
estebank committed Mar 12, 2017
commit 38b5b29c57fc86aae5a1bc8d1319cc08907d9ee0
4 changes: 3 additions & 1 deletion src/librustc_borrowck/borrowck/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -748,7 +748,9 @@ impl<'a, 'tcx> BorrowckCtxt<'a, 'tcx> {
db.span_label(span, &msg);
}
if let Some(span) = local_def {
db.span_label(span, &"this should be `mut`");
if let Ok(snippet) = self.tcx.sess.codemap().span_to_snippet(span) {
db.span_label(span, &format!("consider changing this to `mut {}`", snippet));
}
}
db
}
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/did_you_mean/issue-39544.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ error: cannot borrow immutable field `z.x` as mutable
--> $DIR/issue-39544.rs:21:18
|
20 | let z = Z { x: X::Y };
| - this should be `mut`
| - consider changing this to `mut z`
21 | let _ = &mut z.x;
| ^^^

Expand Down