Nit: LLVM & Clang latest version is 4.0#40704
Nit: LLVM & Clang latest version is 4.0#40704bors merged 1 commit intorust-lang:masterfrom kirillbobyrev:clang_version_bump
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ |
|
📌 Commit fac91c5 has been approved by |
|
🔒 Merge conflict |
|
I've rebased this branch due to a submodule conflict that invalidated many PRs. @bors r=alexcrichton |
|
📌 Commit 71020e3 has been approved by |
…richton Nit: LLVM & Clang latest version is 4.0 Small nit: since latest Clang version is 4.0 it's nice to reflect this in the documentation. Also, I couldn't find anything, but there might be any hard-coded check that Clang version matches "3.X" anywhere in the build system; if there is one, it'd be great to bump that one too.
Small nit: since latest Clang version is 4.0 it's nice to reflect this in the documentation.
Also, I couldn't find anything, but there might be any hard-coded check that Clang version matches "3.X" anywhere in the build system; if there is one, it'd be great to bump that one too.