[beta] Final backports to beta#41427
Merged
Merged
Conversation
Currently the Cargo binary has jumped from 14M to 34M on the beta channel, which appears to be due to the fact that we're compiling tools with debug information inside them. This additionally means that the `rls` binary is 62M right now! This wasn't an intentional change, so be sure to disable debuginfo when compiling tools as it's just intended for the standard library and compile for now.
Contributor
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
|
Member
Author
|
@bors: r+ p=5 (beta backports) |
Collaborator
|
📌 Commit 7b44392 has been approved by |
Collaborator
|
⌛ Testing commit 7b44392 with merge 732672b... |
Collaborator
|
💔 Test failed - status-travis |
Contributor
error[E0369]: binary operation `!=` cannot be applied to type `Mode`
--> /checkout/src/bootstrap/lib.rs:477:12
|
477 | if mode != Mode::Tool {
| ^^^^
| |
Member
Author
|
@bors: r+ |
Collaborator
|
📌 Commit e7eda62 has been approved by |
Collaborator
|
⌛ Testing commit e7eda62 with merge fffafd3... |
Collaborator
|
💔 Test failed - status-appveyor |
Member
Author
|
@bors: retry
|
Collaborator
|
⌛ Testing commit e7eda62 with merge 3cc1e39... |
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: