Fix stat definition for android aarch64#41752
Fix stat definition for android aarch64#41752malbarbo wants to merge 1 commit intorust-lang:masterfrom
Conversation
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
Hm so one reason this whole module is deprecated is that a number of the definitions are known to be incorrect. Is there motivation for correcting them? In theory no code is using these bindings... |
|
My motivation is to make it correct... Maybe there are some one using it in the wild. When I read #31551 I thought that The main problem here is that Is there any problem in making it correct? |
|
The main thing I'm worried about is breaking code which may inadvertently be working today, unfortunately. My guess is that most code, if using this at all, is broken anyway, though. I just personally lean towards not bothering with these modules as they shouldn't be used anyway and fixing them can require nontrivial effort. |
|
Ok. Thanks. |
libc::statfor android aarch64 was change in rust-lang/libc#538, this PR updateraw::statto matchlibc::stat. libc is now tested on aarch64 android, solibc::statshould be correct.Also changed
nlink_ttou64on x86_64 to match the others android archs (and to satisfy #31551)