Suppress trait errors that are implied by other errors#41840
Conversation
There was a problem hiding this comment.
While you're at it, could you clean these up to use //~| instead of //~^^^^^?
arielb1
added
the
S-waiting-on-author
nikomatsakis
left a comment
nikomatsakis
left a comment
There was a problem hiding this comment.
The general approach seems reasonably good to me! Sorry for taking so long to give feedback. I'm a bit unsure if we should maybe try to go further?
|
Friendly ping @arielb1, keeping this on your radar! |
|
☔ The latest upstream changes (presumably #41559) made this pull request unmergeable. Please resolve the merge conflicts. |
|
status: now that I'm done with the segfaults on #41917 I'll look into this - I'll try to get it done by Monday, |
|
Hi @arielb1, how are you getting on with this? |
|
I am. Just a little bit busy with other stuff. |
|
@arielb1 I'm going to close this PR for now just to clear up my queue. Feel free to re-open once you have updates available! |
|
@nikomatsakis You never closed this PR, so I'm going to assume that was unintentional and close it now. Please do reopen if I'm wrong! |
|
@arielb1 I guess you'd prefer to keep the PR open? :) seems fine. |
arielb1
force-pushed
the
deduplicate-selection-errors
branch
from
13ffe4a to
06d6fb2
Compare
arielb1
changed the title
Instead of suppressing only trait errors that are "exact duplicates", display only the "most high-level" error when there are multiple trait errors with the same span that imply each-other. e.g. when there are both `[closure]: Fn` and `[closure]: FnOnce`, omit displaying the `[closure]: FnOnce` bound.
arielb1
force-pushed
the
deduplicate-selection-errors
branch
from
06d6fb2 to
7b9519a
Compare
|
📌 Commit 7b9519a has been approved by |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 7b9519a has been approved by |
|
⌛ Testing commit 7b9519a with merge e6861f5... |
|
💔 Test failed - status-appveyor |
…tsakis Suppress trait errors that are implied by other errors this is currently a hack and should be cleaned up somewhat. Posting this to get some feedback. r? @nikomatsakis cc @estebank
|
☀️ Test successful - status-appveyor, status-travis |
7 participants
this is currently a hack and should be cleaned up somewhat. Posting this to get some feedback.
r? @nikomatsakis
cc @estebank