Merged
Conversation
Contributor
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
| Georges Dubus <georges.dubus@gmail.com> <georges.dubus@compiletoi.net> | ||
| Graham Fawcett <graham.fawcett@gmail.com> Graham Fawcett <fawcett@uwindsor.ca> | ||
| Graydon Hoare <graydon@pobox.com> Graydon Hoare <graydon@mozilla.com> | ||
| Guillaume Gomez <guillaume1.gomez@gmail.com> |
Contributor
There was a problem hiding this comment.
looks like this might be a dup with the one after
Contributor
Author
There was a problem hiding this comment.
No (try removing it and we get duplicates). Maybe there's a more clever way to condense all of Guillaume's contributions with just two total .mailmap directives rather than three?—but finding it doesn't seem like a priority.
Contributor
There was a problem hiding this comment.
wow, mailmaps are very strange
Member
|
Why updating my entry btw? |
arielb1
added
the
S-waiting-on-review
Contributor
|
Thanks for the PR @zackmdavis! @steveklabnik (or someone else) should be reviewing your PR shortly. |
Contributor
Author
To avoid this duplication in the contributors list: |
Contributor
|
@bors: r+ rollup |
Collaborator
|
📌 Commit bc8733f has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Jul 13, 2017
update .mailmap It's nice to have an up-to-date .mailmap so that contributor listings (like those provided by `git shortlog` or http://thanks.rust-lang.org/) don't split the same author's contributions across two or more variations of their name. Affected contributors— @Aaronepower (3 commits as "Aaron Power", 1 as "Aaronepower") @djrollins (5 commits as "Daniel J Rollins", 1 as "Daniel Rollins") @eddyb (345 commits as "Eduard-Mihai Burtescu", 678 as "Eduard Burtescu", assuming former is canonical based on recency and GitHub profile display name) @edunham (1 more recent commit contradicts existing .mailmap entry) @GuillaumeGomez (942 commits as "Guillaume Gomez", 55 commits as "ggomez", 22 commits as "GuillaumeGomez") @jonathandturner (362 commits as "Jonathan Turner", 1 as "jonathandturner") @Mark-Simulacrum (248 commits as "Mark Simulacrum", 97 "Mark-Simulacrum") @fiveop (1 commit each as "Philipp Matthias Schäfer" and "Philipp Matthias Schaefer", assuming former is canonical based on GitHub profile display name) @shyaamsundhar (1 commit as "Shyam Sundar B", 3 as ShyamSundarB, assuming former is canonical based on recency) @steveklabnik (1634 commits as "Steve Klabnik", 41 as "steveklabnik")
bors
added a commit
that referenced
this pull request
Jul 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's nice to have an up-to-date .mailmap so that contributor listings (like those provided by
git shortlogor http://thanks.rust-lang.org/) don't split the same author's contributions across two or more variations of their name.Affected contributors—
@Aaronepower (3 commits as "Aaron Power", 1 as "Aaronepower")
@djrollins (5 commits as "Daniel J Rollins", 1 as "Daniel Rollins")
@eddyb (345 commits as "Eduard-Mihai Burtescu", 678 as "Eduard Burtescu", assuming former is canonical based on recency and GitHub profile display name)
@edunham (1 more recent commit contradicts existing .mailmap entry)
@GuillaumeGomez (942 commits as "Guillaume Gomez", 55 commits as "ggomez", 22 commits as "GuillaumeGomez")
@jonathandturner (362 commits as "Jonathan Turner", 1 as "jonathandturner")
@Mark-Simulacrum (248 commits as "Mark Simulacrum", 97 "Mark-Simulacrum")
@fiveop (1 commit each as "Philipp Matthias Schäfer" and "Philipp Matthias Schaefer", assuming former is canonical based on GitHub profile display name)
@shyaamsundhar (1 commit as "Shyam Sundar B", 3 as ShyamSundarB, assuming former is canonical based on recency)
@steveklabnik (1634 commits as "Steve Klabnik", 41 as "steveklabnik")