[beta] Remove rls from the workspace and extended builds#43199
Closed
cuviper wants to merge 1 commit into
Closed
Conversation
Its git dependencies don't work when building with vendored crates, so for now it will just be removed from the workspace and disabled in the rustbuild rules. cc rust-lang#42719
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
|
Member
Collaborator
|
📌 Commit 6d6fccb has been approved by |
Collaborator
|
⌛ Testing commit 6d6fccb with merge 4f9ee81fc474ed85defdebd10fbe45607b6d103c... |
Collaborator
|
💔 Test failed - status-travis |
Member
|
@bors: r+ p=25
|
Collaborator
|
💡 This pull request was already approved, no need to approve it again.
|
Collaborator
|
📌 Commit 6d6fccb has been approved by |
alexcrichton
added
the
S-waiting-on-bors
Member
|
I'm going to manually roll this into #43208 to get the new beta out sooner, so closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its git dependencies don't work when building with vendored crates,
so for now it will just be removed from the workspace and disabled in
the rustbuild rules.
cc #42719