Add #[derive(Clone)] to TokenTreeIter#43280
Merged
Merged
Conversation
carols10cents
added
the
S-waiting-on-review
Member
|
cc @nrc, you may also be able to take a look at this! |
Member
|
@bors: r+ |
Collaborator
|
📌 Commit b525abb has been approved by |
Contributor
|
@bors rollup |
Collaborator
|
⌛ Testing commit b525abb with merge 1bdd10ce04329ec3e2ceaeb26a905f61441799a3... |
Collaborator
|
💔 Test failed - status-travis |
Contributor
Contributor
|
@bors retry (a current retried build appears to have got past the issue, so the cached dockerfile should be used from now on which will hopefully resolve the issue) |
TimNN
added a commit
to TimNN/rust
that referenced
this pull request
Jul 21, 2017
Add #[derive(Clone)] to TokenTreeIter I've found this useful for writing backtracking parsers. The underlying `Cursor` implements `Clone` already, so it's just a matter of adding `#[derive(Clone)]` to the type. r? @jseyfried
bors
added a commit
that referenced
this pull request
Jul 21, 2017
Collaborator
bors
added a commit
that referenced
this pull request
Jul 24, 2017
Add #[derive(Clone)] to TokenTreeIter I've found this useful for writing backtracking parsers. The underlying `Cursor` implements `Clone` already, so it's just a matter of adding `#[derive(Clone)]` to the type. r? @jseyfried
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found this useful for writing backtracking parsers.
The underlying
CursorimplementsClonealready, so it's just a matter of adding#[derive(Clone)]to the type.r? @jseyfried