rustc: Flag {i,u}128 as unsafe for FFI#44261
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 3, 2017
Merged
Conversation
Contributor
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
eddyb
approved these changes
Sep 2, 2017
Member
|
@bors r+ |
Collaborator
|
📌 Commit 4fe2647 has been approved by |
Member
|
@bors r- Travis failed. |
5 tasks
These don't appear to have a stable ABI as noted in rust-lang#41799 and the work in compiler-builtins definitely seems to be confirming it!
4fe2647 to
549dd10
Compare
Member
Author
|
@bors: r=eddyb |
Collaborator
|
📌 Commit 549dd10 has been approved by |
Collaborator
|
⌛ Testing commit 549dd10 with merge 9ed8f8c0003315fdf505641ac79510891cc18cc3... |
Collaborator
|
💔 Test failed - status-appveyor |
Member
|
Details |
Collaborator
bors
added a commit
that referenced
this pull request
Sep 3, 2017
rustc: Flag {i,u}128 as unsafe for FFI
These don't appear to have a stable ABI as noted in #41799 and the work in
compiler-builtins definitely seems to be confirming it!
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These don't appear to have a stable ABI as noted in #41799 and the work in
compiler-builtins definitely seems to be confirming it!