Merged
Conversation
Member
|
I think having multiple independently scrollable components is one of the negative things about doxygen. |
Member
|
This would force me to move my mouse to the sidebar if I wanted to scroll inside it. Previously you can easily scroll with pgup/pgdown. |
Contributor
|
Ehhhh, i'm +0 about this. I'm not sure it adds or detracts anything. |
Member
|
👍 if it is |
QuietMisdreavus
added
I-nominated
A-docs
GuillaumeGomez
force-pushed
the
sidebar-fixed
branch
from
30610fc to
9ce41f2
Compare
Member
Author
|
The @rust-lang/docs gave its go yesterday once the @bors: r=QuietMisdreavus rollup |
Collaborator
|
📌 Commit 9ce41f2 has been approved by |
kennytm
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 25, 2017
…etMisdreavus Limit the sidebar height The sidebar is now fixed, which means its scrolling is independent of the main page now. r? @rust-lang/docs
bors
added a commit
that referenced
this pull request
Oct 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sidebar is now fixed, which means its scrolling is independent of the main page now.
r? @rust-lang/docs